Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug email subject settings #3030

Merged
merged 16 commits into from
Sep 2, 2022
Merged

Debug email subject settings #3030

merged 16 commits into from
Sep 2, 2022

Conversation

joemull
Copy link
Member

@joemull joemull commented Jul 22, 2022

Closes #2313.

The following email subject settings were broken and had no effect. Now they will correctly populate outgoing emails.

  • subject_unassign_editor
  • subject_review_complete_acknowledgement
  • subject_review_decision_accept
  • subject_review_decision_decline
  • subject_copyediting_decision
  • subject_author_publication
  • subject_section_editor_pub_notification
  • subject_peer_reviewer_pub_notification
  • subject_revisions_complete_receipt

Editors are encouraged to check any of these settings that have been modified in the past.

joemull and others added 15 commits July 13, 2022 15:45
@joemull
#2313 Ignore development files when loading notify plugins
a415ef3
@joemull
#2313 Add testing helper for editor assignments
03efd55
@joemull
#2313 Fix bug that meant language or translation of setting wasn't re…
74cec70 
…cognized
@joemull
#2313 Fix bugs causing incorrect email subjects
f143ce1
@joemull
#2313 Add testing helper for revision requests
f7b8b9e
@joemull
#2313 Add testing helpers for Copyeditor and Copyedit Assignment
1d9d00e
@joemull
#2313 More tests; strengthen tests to fail if no setting
58219b7
@joemull
#2313 Add default for copyeditor accepting or declining task
4360d9c
@joemull
#2313 Add testing helpers for section editor and peer reviewer
b1f6f2a
@joemull
#2313 Fix four email subject bugs
84cacef
@joemull
#2313 Organize and expand tests
2a8990e
@joemull
Simplify submission models import in testing helpers
ae1acac
@joemull
#2313 Additional review stage tests and fixes
b3f1270
@joemull
#2313 Add testing helper for access request
33b3d55
@joemull
#2313 Add email subject tests for decision drafts and access requests
e00d2eb
@joemull joemull requested review from ajrbyers and mauromsl July 22, 2022 14:24
@joemull joemull marked this pull request as ready for review July 22, 2022 14:24
@ajrbyers
Copy link
Member

ajrbyers commented Sep 1, 2022

@joemull I've approved this but there are conflicts that need to be resolved.

@joemull
Copy link
Member Author

joemull commented Sep 1, 2022

OK I resolved the conflict @ajrbyers.

@joemull joemull merged commit 5869727 into master Sep 2, 2022
@joemull joemull deleted the 2313-email-subject-bugfix branch September 2, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers ajrbyers approved these changes

@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email Subjects
2 participants
@joemull @ajrbyers