Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1953 implementation #1959

Merged
merged 44 commits into from
Feb 8, 2021
Merged

1953 implementation #1959

merged 44 commits into from
Feb 8, 2021

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Dec 21, 2020 •
edited
Loading

Closes #1953
Closes #1963

ajrbyers and others added 30 commits December 17, 2020 13:07
@ajrbyers
Template URL implenentation for editor_new_submission
f1290cb
@ajrbyers
#1953 implementation for new_user_registration
8052f62
@ajrbyers
#1953 fixes implementation for new_user_registration
1c4c0a9
@ajrbyers
#1953 implementation for password_reset
0860ee2
@ajrbyers
#1953 implementation for user_email_change
6a20add
@ajrbyers
#1952 completes implementation of review_unassigned_article_url
84e25ae
@ajrbyers
#1953 adds implementation for editor_assignment
eb4ee80
@ajrbyers
#1953 adds implementation for review accept/decline
0cadf06
@ajrbyers
#1953 added implementation for review_complete_acknowledgement
708a470
@mauromsl
#1953: Fix copyedit assignment email
2656a01
@mauromsl
#1953: Fix author copyedit review url
ad95108
@mauromsl
#1953: Fix copyedit reopen url
b5e4081
@mauromsl
#1953: Start using copyedit complete email template
7d66917
@ajrbyers
#1953 removes the review_request_sent email.
2c07a03
@ajrbyers
#1953 fixes previous commit
01ae299
@mauromsl
#1953: Fix proofing assignment email
068795c
@mauromsl
#1953: Fix proofreader assignment email
2fa0f7d
@mauromsl
#1953: Fix proofreader complete email
01edf71
@mauromsl
#1953: Fix proofreading changes email
2d6276d
@ajrbyers
#1953 implementation for request_revisions email
eddfa00
@ajrbyers
#1953 removes link from production_complete
4d87832
@ajrbyers
#1953 Fixes the production complete email process.
bf2ac0d
@ajrbyers
#1953 adds typesetter_requests_url to typesetter notification
8bdbcf5
@ajrbyers
#1953 implements now url insertion for typesetter_complete_notification
0c2a135
@ajrbyers
1953 new url implementation for typesetter_corrections_complete
ace3180
@ajrbyers
#1953 removed link from notify_editor_proofing_complete as it was wor…
fc000ca 
…kflow specific
@ajrbyers
#1953 author_copyedit_complete
d842746
@ajrbyers
#1953 fixes the email sent on author review request.
27b927e
@ajrbyers
#1953 removes print statement
53bdd30
@ajrbyers
#1953 fixes the author_copyedit_complete email.
7503367
mauromsl
mauromsl requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some inconsistencies on the new JSON defaults that don't match the migrations

@ajrbyers
Copy link
Member Author

ajrbyers commented Feb 4, 2021

Notes from Testing

  • Proofing
    • Correction request email should go to /proofing/requests/corrections/ not /proofing/requests/
    • When undertaking corrections the View Metadata will post the form
    • Proofing complete email sends you to Production rather than Proofing
  • Typesetting Plugin
    • When proofing complete email is sent add link to Typesetting article page

@mauromsl mauromsl self-requested a review February 8, 2021 18:14
@mauromsl mauromsl merged commit 77ffcae into master Feb 8, 2021
@mauromsl mauromsl deleted the 1953-implementation branch February 8, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email Template: review_complete_reviewer_acknowledgement Email Template URLs
2 participants
@ajrbyers @mauromsl