#1851 adds drag and drop ordering for review form elements #1853

ajrbyers · 2020-10-07T10:02:24Z

This PR:

Adds a generic function for reordering objects (if approved a new Issue to be created to convert others to use it)
Adds a generic sortable html template for inclusion in block_js
Adds sortable stuff to edit review form view
Adds default ordering to the ReviewFormElement model

mauromsl

This now conflicts with master, needs rebasing/merging
Couple of nitpicks inline

src/templates/admin/core/kanban.html

src/utils/shared.py

src/review/migrations/0008_auto_20201007_1002.py

ajrbyers added 2 commits October 7, 2020 11:00

#1851 adds drag and drop ordering for review form elements

e8209a8

#1851 adds meta migration

b9b9eee

ajrbyers requested a review from mauromsl October 7, 2020 10:04

ajrbyers added 2 commits October 7, 2020 11:05

#1851 moves utils.shared import to line above

d649e81

#1851 added generic sortable template.

ac3dc24

mauromsl requested changes Oct 8, 2020

View reviewed changes

src/templates/admin/core/kanban.html Outdated Show resolved Hide resolved

src/utils/shared.py Outdated Show resolved Hide resolved

ajrbyers added 3 commits October 8, 2020 12:42

#1851 remove backticks

ca1364c

#1851 PEP8-ify utils.shared.set_order

818a82d

Merge branch 'master' into 1851-easy_order_review_elements

683d3f3

mauromsl requested changes Oct 8, 2020

View reviewed changes

src/review/migrations/0008_auto_20201007_1002.py Outdated Show resolved Hide resolved

#1851 regenerated migration

e8920fe

ajrbyers requested a review from mauromsl October 8, 2020 12:14

mauromsl approved these changes Oct 8, 2020

View reviewed changes

mauromsl merged commit 13ec490 into master Oct 8, 2020

mauromsl deleted the 1851-easy_order_review_elements branch October 8, 2020 12:21

Provide feedback