Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication: Fix integrity issues when editing a user profile with mixed case email addresses #1807

Merged
merged 7 commits into from
Sep 28, 2020

Conversation

mauromsl
Copy link
Member

Addresses some bugs:

  • When a user edits their own email address, the user model is cleaned. If the username/email are in use the form won't validate.
  • usernames won't be set to mixed case values when editing an account anymore
  • When an editor edits another user's email address, the user model is cleaned.

Adds authentication tests for:

  • Avoiding registration of accounts with the same email address with variations in the casing
  • Ensuring the email address field in the login system is case insensitive.

@mauromsl mauromsl changed the title Auth casing tests Authentication: Fix integrity issues when editing a user profile with mixed case email addresses Sep 11, 2020
@mauromsl mauromsl requested a review from ajrbyers September 11, 2020 16:32
@ajrbyers ajrbyers merged commit 9cbe385 into master Sep 28, 2020
@ajrbyers ajrbyers deleted the auth-casing-tests branch September 28, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants