Feature hooks #1492
Merged
Feature hooks #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauromsl
requested changes
Apr 6, 2020
Yes dashboard cards for typesetter and proofreader yes. Swimlanes are already done (handled by |
…. Removed most branches except unassigned.
…to super().valid_value()
|
Should be ready for re-review now. |
mauromsl
requested changes
Apr 16, 2020
mauromsl
requested changes
Apr 17, 2020
src/core/workflow.py
Outdated
| @@ -169,11 +169,15 @@ def articles_in_workflow_stages(request): | |||
| workflow_list[element.element_name] = element_dict | |||
| except (KeyError, AttributeError) as e: | |||
| if settings.DEBUG: | |||
There was a problem hiding this comment.
we should log this in production as well, no?
src/submission/models.py
Outdated
Comment on lines
320
to
321
| # Check if the value is in dynamic choices and remove the | ||
| # error message if it is |
There was a problem hiding this comment.
This is slightly inaccurate now
mauromsl
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LANGUAGE_CODEto global settings as this was breaking the Clean themecore.models.BASE_ELEMENTSandcore.models.WorkflowElementhandshake_url to correct: this should be the "list" page for the element (migrations added to fix the DB)core.models.has_missing_image_filesfor files that aren't XML.core.models.WorkflowElementthat let us see what stages are part of a element and which articles are in those stagescore.templatetags.hooksno takes*argsand**kwargssubmission.models.Article.current_stagerequest.journal.workflowrequest.journal.workflowutils.install.update_settingsnow allows for a path to load other settings with a defaultutils/install/journal_defaults.jsonutils.management.commands.install_pluginsnow accepts an option argumentplugin_nameso you can fire the install process for a single plugin eg../manage.py install_plugins typesetting