Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CMYK images #1483

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Handle CMYK images #1483

merged 2 commits into from
Mar 26, 2020

Conversation

mauromsl
Copy link
Member

closes #1482

ajrbyers
ajrbyers requested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check my comment?

src/core/logic.py Outdated
@@ -111,6 +111,8 @@ def resize_and_crop(img_path, size, crop_type='middle'):
img = img.crop(box)
else:
img = img.resize((size[0], size[1]), Image.ANTIALIAS)
if img.mode == "CMYK":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be indented under the else here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

ajrbyers
ajrbyers approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice. 🎖️

@ajrbyers ajrbyers merged commit b67d310 into master Mar 26, 2020
@ajrbyers ajrbyers deleted the 1482-Bugfix branch March 26, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers ajrbyers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMYK images break on upload: 'cannot write mode CMYK as PNG'
2 participants
@mauromsl @ajrbyers