1322 most downloaded article #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #1344 1322 |
mauromsl
requested changes
Nov 14, 2019
| self.fields['most_downloaded_time'].initial = most_downloaded_time | ||
|
|
||
| most_downloaded = forms.BooleanField( | ||
| label='Display Most Downloaded Articles', |
There was a problem hiding this comment.
Should this say, most popular or most visited since we are not filtering downloads but general accesses?
(same applies to the references to "downloads" below
| help_text='Determines how many popular articles we should display.', | ||
| ) | ||
|
|
||
| def save(self, journal, commit=True): |
There was a problem hiding this comment.
I don't think we should override the signature of save to take in a journal. Especially since you already expect a journal to be passed to the constructor
| request.journal | ||
| ) | ||
|
|
||
| if most_downloaded: |
There was a problem hiding this comment.
this means we can't have both most downloaded and featured articles at the same time.
Perhaps the "most downloaded" should be a homepage element of its own, so you can choose to have, neither, one, the other or both
Beethro
pushed a commit
to TUWBIB/janeway
that referenced
this pull request
Feb 10, 2020
* Partial commit. * Form now works as expected. * Initial pass over. * Changed title on OLH theme * Switched to Processed Values. * Fixed query. * Partial: adds dt filtering. * openlibhums#1322: Use natural join filters instead of subquery * When articles have the same number of accesses, order by title. * Brought most popular articles to Default and Material. * Reset featured. * Resets featured templates. * Added new popular homepage element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.