Added settings to limit the number of proofreaders by round.

src/core/forms.py

@@ -299,6 +299,7 @@ def __init__(self, *args, **kwargs):
                     widget=forms.CheckboxInput(attrs={'is_checkbox': True}),
                     required=False)
 
+            self.fields[field['name']].label = object.setting.pretty_name
             self.fields[field['name']].initial = object.processed_value
             self.fields[field['name']].help_text = object.setting.description
 

src/core/logic.py

@@ -289,6 +289,12 @@ def get_settings_to_edit(group, journal):
             'object': setting_handler.get_setting('email', 'from_address', journal),
         })
 
+    elif group == 'proofing':
+        proofing_settings = [
+            'max_proofreaders'
+        ]
+        settings = process_setting_list(proofing_settings, 'general', journal)
+        setting_group = 'general'
     else:
         settings = []
         setting_group = None

src/proofing/models.py

@@ -7,6 +7,7 @@
 from django.utils import timezone
 
 from events import logic as event_logic
+from utils import setting_handler
 
 
 class ProofingAssignment(models.Model):
@@ -108,6 +109,30 @@ def delete_round_relations(self, request, article, tasks, corrections):
                 )
                 correction.delete()
 
+    def can_add_another_proofreader(self, journal):
+        """
+        Checks if this round can have another proofreader.
+        :param journal: Journal object
+        :return: Boolean, True or False
+        """
+
+        limit = setting_handler.get_setting(
+            'general',
+            'max_proofreaders',
+            journal,
+        ).processed_value
+
+        if not limit == 0:
+
+            current_num_proofers = ProofingTask.objects.filter(
+                round=self,
+            ).count()
+
+            if current_num_proofers >= limit:
+                return False
+
+        return True
+
 
 class ProofingTask(models.Model):
     round = models.ForeignKey(ProofingRound)

src/proofing/views.py

@@ -122,9 +122,18 @@ def proofing_article(request, article_id):
     :param article_id: Article object PK
     :return: HttpRedirect if POST or HttpResponse
     """
-    article = get_object_or_404(submission_models.Article.objects.select_related('productionassignment'), pk=article_id,
-                                journal=request.journal)
-    proofreaders = logic.get_all_possible_proofers(journal=request.journal, article=article)
+    article = get_object_or_404(
+        submission_models.Article.objects.select_related(
+            'productionassignment'
+        ),
+        pk=article_id,
+        journal=request.journal,
+    )
+    current_round = article.proofingassignment.current_proofing_round()
+    proofreaders = logic.get_all_possible_proofers(
+        journal=request.journal,
+        article=article,
+    )
     form = forms.AssignProofreader()
     modal = None
 
@@ -133,10 +142,34 @@ def proofing_article(request, article_id):
         if 'new-round' in request.POST:
             logic.handle_closing_active_task(request, article)
             new_round = article.proofingassignment.add_new_proofing_round()
-            messages.add_message(request, messages.SUCCESS, 'New round {0} added.'.format(new_round.number))
-            return redirect(reverse('proofing_article', kwargs={'article_id': article.pk}))
+            messages.add_message(
+                request,
+                messages.SUCCESS,
+                'New round {0} added.'.format(new_round.number),
+            )
+            return redirect(
+                reverse(
+                    'proofing_article',
+                    kwargs={'article_id': article.pk},
+                )
+            )
 
         if 'new-proofreader' in request.POST:
+
+            if not current_round.can_add_another_proofreader(request.journal):
+                messages.add_message(
+                    request,
+                    messages.WARNING,
+                    'The number of proofreaders per round has been limited.'
+                    ' You cannot add another proofreader in this round.',
+                )
+                return redirect(
+                    reverse(
+                        'proofing_article',
+                        kwargs={'article_id': article.pk},
+                    )
+                )
+
             form = forms.AssignProofreader(request.POST)
             user = logic.get_user_from_post(request, article)
             galleys = logic.get_galleys_from_post(request)
@@ -150,7 +183,7 @@ def proofing_article(request, article_id):
             if form.is_valid():
                 proofing_task = form.save(commit=False)
                 proofing_task.proofreader = user
-                proofing_task.round = article.proofingassignment.current_proofing_round()
+                proofing_task.round = current_round
                 proofing_task.save()
                 proofing_task.galleys_for_proofing.add(*galleys)
                 return redirect(

src/templates/admin/core/manager/index.html

@@ -54,7 +54,14 @@ <h2>Submission Setup</h2>
 
         <div class="large-3 columns end">
             <div class="box" data-equalizer-watch>
-
+                <div class="title-area">
+                    <h2>Workflow Setup</h2>
+                </div>
+                <div class="content">
+                    <div class="button-group stacked">
+                        <a class="button" href="{% url 'core_edit_settings_group' "proofing" %}">Proofing Settings</a>
+                    </div>
+                </div>
                 <div class="title-area">
                     <h2>Content</h2>
                 </div>

src/templates/admin/proofing/proofing_article.html

@@ -5,6 +5,7 @@
 {% load foundation %}
 {% load roles %}
 {% load render_string %}
+{% load i18n %}
 
 {% block title %}Proofing - {{ article.pk }}{% endblock title %}
 {% block title-section %}Proofing{% endblock %}
@@ -255,6 +256,16 @@ <h2>Steps</h2>
             </div>
             <div class="content">
             {% render_string journal_settings.general.proofing_steps %}</div>
+
+            {% if not journal_settings.general.max_proofreaders.processed_value %}
+                <div class="title-area">
+                    <h2>Notes</h2>
+                </div>
+                <div class="content">
+                    <p>{% trans "Each proofing round is limited to" %} {{ journal_settings.general.max_proofreaders }} {% trans "proofreaders" %}.</p>
+                </div>
+            {% endif %}
+
         </div>
         <div class="box">
             <div class="title-area">

src/utils/install/journal_defaults.json

@@ -428,7 +428,7 @@
             "is_translatable": false,
             "name": "max_dois",
             "pretty_name": "Maximum preprint DOIs per month",
-            "type": "integer"
+            "type": "number"
         },
         "value": {
             "default": "100"
@@ -2593,5 +2593,20 @@
         "group": {
             "name": "general"
         }
+    },
+    {
+        "group": {
+            "name": "general"
+        },
+        "setting": {
+            "description": "The maximum number of proofreaders allowed per round. To disable this set to 0.",
+            "is_translatable": false,
+            "name": "max_proofreaders",
+            "pretty_name": "Maximum Proofreders per Round",
+            "type": "number"
+        },
+        "value": {
+            "default": "0"
+        }
     }
 ]