Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staff cannot send publication notification emails in certain circumstances #4477

Closed
ajrbyers opened this issue Nov 4, 2024 · 0 comments · Fixed by #4478
Closed

Staff cannot send publication notification emails in certain circumstances #4477

ajrbyers opened this issue Nov 4, 2024 · 0 comments · Fixed by #4478
Assignees
@ajrbyers
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. priority-urgent size S Small

Comments

@ajrbyers
Copy link
Member

ajrbyers commented Nov 4, 2024

Describe the bug
A production manager was attempting to send a publication notification but received an error.

Janeway version
1.7.

To Reproduce
Steps to reproduce the behavior:

  1. The circumstances are hard to replicate, recommend pulling a copy of the Michigan database
  2. Can be replicated by having an article with no reviewers but notifying reviewers is enabled

Expected behavior
The email should be sent without error assuming the form is okay
@ajrbyers ajrbyers added the bug Something's not working label Nov 4, 2024
@ajrbyers ajrbyers self-assigned this Nov 4, 2024
@ajrbyers ajrbyers added size S Small dev-ready This issue has been refined and is ready for development. priority-urgent labels Nov 4, 2024
ajrbyers added a commit that referenced this issue Nov 4, 2024
@ajrbyers
#4477 fixes two bugs related to notifications in prepub
b9d5177
@ajrbyers ajrbyers mentioned this issue Nov 4, 2024
Merged
StephDriver pushed a commit that referenced this issue Nov 5, 2024
@ajrbyers @StephDriver
#4477 fixes two bugs related to notifications in prepub
d0e7c67
@ajrbyers ajrbyers closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajrbyers ajrbyers

Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. priority-urgent size S Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes two issues related to prepublication author and reviewer notifications openlibhums/janeway
1 participant
@ajrbyers