Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element IDs are not unique #3909

Closed
StephDriver opened this issue Jan 24, 2024 · 3 comments · Fixed by #4183
Closed

element IDs are not unique #3909

StephDriver opened this issue Jan 24, 2024 · 3 comments · Fixed by #4183
Assignees
@StephDriver
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. priority-medium Medium priority
Milestone
A11y Improvements...

Comments

@StephDriver
Copy link
Contributor

example page is https://www.iastatedigitalpress.com/mmb/article/id/13894/

tables and tags have duplicate element IDs, possibly more than those.
@StephDriver StephDriver added the a11y Issues that relate to acessibility label Jan 24, 2024
@ajrbyers
Copy link
Member

ajrbyers commented Mar 8, 2024

This issue is caused by the table being duplicated for the View Larger modal. The new table should be assigned a new ID.

@ajrbyers ajrbyers added dev-ready This issue has been refined and is ready for development. priority-medium Medium priority labels Mar 8, 2024
@ajrbyers
Copy link
Member

ajrbyers commented Mar 14, 2024 •
edited by StephDriver
Loading

  • Change table id in modal
  • Remove all other ids/anchors
  • @StephDriver add a new issue to consider better way to manage "larger" versions of tables in the a11y context

@StephDriver
Copy link
Contributor Author

#4055 added to consider use of tables in general, which will then drill down into A11y improvements for each usecase.

@StephDriver StephDriver added this to the A11y Phase 1 milestone Apr 10, 2024
@StephDriver StephDriver moved this to Triage in Accessibility Apr 12, 2024
@StephDriver StephDriver self-assigned this Apr 29, 2024
StephDriver added a commit that referenced this issue May 16, 2024
@StephDriver
#3909 table popups updated to have unique ids
2c2630b
@StephDriver StephDriver mentioned this issue May 16, 2024
Merged
@StephDriver StephDriver moved this from Triage to Sent to Dev in Accessibility May 16, 2024
ajrbyers pushed a commit that referenced this issue May 16, 2024
@StephDriver @ajrbyers
#3909 table popups updated to have unique ids
8e89eea
@github-project-automation github-project-automation bot moved this from Sent to Dev to Done in Accessibility May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephDriver StephDriver

Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. priority-medium Medium priority
Projects
Accessibility
Status: Done
Milestone
A11y Improvements - Phase 1
Development

Successfully merging a pull request may close this issue.

#3909 table popups updated to have unique ids openlibhums/janeway
2 participants
@StephDriver @ajrbyers