Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email log has wrong property name #3810

Closed
joemull opened this issue Dec 7, 2023 · 1 comment · Fixed by #4070
Closed

Email log has wrong property name #3810

joemull opened this issue Dec 7, 2023 · 1 comment · Fixed by #4070
Assignees
@ajrbyers
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. size XS Extra small

Comments

@joemull
Copy link
Member

joemull commented Dec 7, 2023

I think the property on this line is wrong:

https://github.com/BirkbeckCTP/janeway/blob/e8176e51c8847744ca80be19c642bdfd2402c5d2/src/core/email.py#L29

It should be action_text as picked up here:

https://github.com/BirkbeckCTP/janeway/blob/e8176e51c8847744ca80be19c642bdfd2402c5d2/src/utils/notify_plugins/email_log.py#L22
@joemull joemull added the bug Something's not working label Dec 7, 2023
@ajrbyers ajrbyers added size M Medium size XS Extra small and removed size M Medium labels Mar 14, 2024
@ajrbyers
Copy link
Member

ajrbyers commented Mar 14, 2024 •
edited by joemull
Loading

  • @joemull open new issue to convert log_dict text to constants

@ajrbyers ajrbyers added the dev-ready This issue has been refined and is ready for development. label Mar 14, 2024
@joemull joemull mentioned this issue Mar 14, 2024
Open
ajrbyers added a commit that referenced this issue Mar 28, 2024
@ajrbyers
#3810 update instances of action_type to action_text
c072e17
@ajrbyers ajrbyers mentioned this issue Mar 28, 2024
Merged
@ajrbyers ajrbyers self-assigned this Mar 28, 2024
StephDriver pushed a commit that referenced this issue Apr 4, 2024
@ajrbyers @StephDriver
#3810 update instances of action_type to action_text
91f5708
ajrbyers added a commit that referenced this issue May 10, 2024
@ajrbyers
#3810 update instances of action_type to action_text
d6371be
mauromsl pushed a commit that referenced this issue May 14, 2024
@ajrbyers @mauromsl
#3810 update instances of action_type to action_text
3b2563e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajrbyers ajrbyers

Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. size XS Extra small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3810 fixes a bug where action_text was not being recorded for two email types openlibhums/janeway
2 participants
@ajrbyers @joemull