Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orphan articles (not associated with any journal) cause the /manager page to throw an error #3598

Closed
hardyoyo opened this issue Jun 6, 2023 · 0 comments · Fixed by #3614
Closed
Assignees
Labels
bug Something's not working

Comments

@hardyoyo
Copy link
Contributor

hardyoyo commented Jun 6, 2023

Describe the bug
If one has a small collection of orphan articles (not associated with any journal), the /manager page ceases to function. Specifically, it throws this error:

https://gist.github.com/hardyoyo/6a0a765ef55ed0b6cc5c28ee9c68f15a

The manager page should be made more resilient, so it can tolerate the presence of orphan articles.

Janeway version
v1.5.0-RC-4

To Reproduce
Steps to reproduce the behavior:

  1. Have a journal with some test articles
  2. using an SQL tool, remove the journal_id for an article
  3. Attempt to visit the /manager url for your site
  4. See error

Expected behavior
The manager page should work, despite the presence of orphaned articles. It could be nice to provide a count of orphaned articles and a warning that they exist. But that's not necessary to address this ticket. The page should just work.

Screenshots
n/a

Front-end Issues

n/a

Desktop (please complete the following information):
n/a

Smartphone (please complete the following information):
n/a

Additional context
n/a

@hardyoyo hardyoyo added the bug Something's not working label Jun 6, 2023
@ajrbyers ajrbyers self-assigned this Jun 26, 2023
ajrbyers added a commit that referenced this issue Jun 28, 2023
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.5.1 Archer Jun 28, 2023
mauromsl pushed a commit that referenced this issue Sep 15, 2023
@github-project-automation github-project-automation bot moved this from 📝 PR Submitted to ✅ Done in v1.5.1 Archer Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working
Projects
No open projects
Status: Done
2 participants