Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ORCID field to support inputs in both short and long (URI) form #2781

Closed
joemull opened this issue Mar 4, 2022 · 3 comments · Fixed by #2906
Closed

Update ORCID field to support inputs in both short and long (URI) form #2781

joemull opened this issue Mar 4, 2022 · 3 comments · Fixed by #2906
Assignees
Labels
new feature A new thing that doesn't exist yet

Comments

@joemull
Copy link
Member

joemull commented Mar 4, 2022

Is your feature request related to a problem? Please describe.
Currently some inputs to the ORCID field cause problems with DOI registration, or don't behave as expected in other ways.

Describe the solution you'd like
Use regular expressions to detect various ORCID forms and store a uniform version of the ORCID, even if it is still served or displayed in various ways through the GUI.

@joemull joemull added the new feature A new thing that doesn't exist yet label Mar 4, 2022
@joemull joemull changed the title Update DOI field to support inputs in both short and long (URI) form Update ORCID field to support inputs in both short and long (URI) form Mar 4, 2022
@joemull joemull added this to v1.4.2 Mar 8, 2022
@joemull joemull modified the milestone: 1.4.2 Mar 8, 2022
@joemull joemull moved this to Todo in v1.4.2 Mar 8, 2022
@alainna
Copy link
Contributor

alainna commented Mar 8, 2022

Please reconsider this. There should be no manual inputs of ORCID iDs. Rather, perhaps there should be a standardisation of input for ORCID iDs -- and, tbh, DOIs. e.g. if iD isn't in X format (0000-000x-xxxx-xxxx / https://orcid.org/0000-000x-xxxx-xxxx), then it should be updated accordingly. If the input is unable to be standardised, then user is shown error and told how to correct ("ORCID iD must be in X format").

@ajrbyers
Copy link
Member

ajrbyers commented Mar 8, 2022

Please reconsider this. There should be no manual inputs of ORCID iDs.

Its a great goal but realistically, thats not going to be possible.

@ajrbyers
Copy link
Member

ajrbyers commented Mar 8, 2022

if iD isn't in X format (0000-000x-xxxx-xxxx / https://orcid.org/0000-000x-xxxx-xxxx), then it should be updated accordingly. If the input is unable to be standardised, then user is shown error and told how to correct ("ORCID iD must be in X format").

This is the goal here. We will store it in a single format after checking that its valid.

ajrbyers added a commit that referenced this issue Jun 6, 2022
ajrbyers added a commit that referenced this issue Jun 7, 2022
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.4.2 Jun 9, 2022
@ajrbyers ajrbyers self-assigned this Jun 9, 2022
Repository owner moved this from PR Submitted to Done in v1.4.2 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new thing that doesn't exist yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants