Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer reviewers with one-click access cannot see due date #2711

Closed
4 tasks done
joemull opened this issue Jan 17, 2022 · 0 comments · Fixed by #3018
Closed
4 tasks done

Peer reviewers with one-click access cannot see due date #2711

joemull opened this issue Jan 17, 2022 · 0 comments · Fixed by #3018
Assignees
Labels
bug Something's not working

Comments

@joemull
Copy link
Member

joemull commented Jan 17, 2022

An editor reported a reviewer could not find the due date for the review anywhere. This can happen if one-click-access is turned on for reviewers, as the review request view does not include the date. If the review request email also does not include the due date, as is default, the reviewer won't see it anywhere.

We can:

  • Add the due date to the review request view, including the one-click endpoint
  • Add the due date to the default review request email template: {{ review_request.date_due }}
  • Add the template variable for due date to the documentation or help text for the review reqeuest template setting.
  • Where a review_assignment template has not been editted, overwrite it with the new value
@joemull joemull added the bug Something's not working label Jan 17, 2022
@joemull joemull added this to the 1.4.2 milestone Jan 17, 2022
@ajrbyers ajrbyers removed this from the 1.4.2 milestone Jul 20, 2022
@ajrbyers ajrbyers self-assigned this Jul 20, 2022
@ajrbyers ajrbyers added this to v1.4.3 Jul 20, 2022
@ajrbyers ajrbyers moved this to Todo in v1.4.3 Jul 20, 2022
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.4.3 Jul 21, 2022
ajrbyers added a commit that referenced this issue Sep 8, 2022
joemull added a commit that referenced this issue Sep 13, 2022
#2711 review due dates are now in the default invitation and on the review page.
Repository owner moved this from PR Submitted to Done in v1.4.3 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants