Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprints: Newly added first authors are not displaying in dashboard view #2575

Closed
alainna opened this issue Nov 3, 2021 · 0 comments
Closed
Labels
bug Something's not working

Comments

@alainna
Copy link
Contributor

alainna commented Nov 3, 2021

Describe the bug
Dashboard does not display First Author for new author relationships to preprints created after our latest update (preprint-merge branch?). Author order remains correct in item view.

Janeway version
Preprints 1.4.0

To Reproduce
Confirm "First Author" role is working in some places:

  1. Navigate to existing, published submission with multiple authors in moderator dashboard.
  2. Set new author as First Author
  3. Confirm new First Author correctly displays as First Author in item public view and in moderator dashboard.

Create new preprint:

  1. Make a new submission with 1-2 authors
  2. View submission in moderator dashboard view.
  3. Confirm new First Author correctly displays as First Author in item public view
  4. Note that preprint lacks a "First Author" in moderator dashboard.

Add new author from account table to existing preprint:

  1. Navigate to existing, published submission with multiple authors in moderator dashboard.
  2. Add an existing account as a new author, then set that author as First Author
  3. Confirm new First Author correctly displays as First Author in item public view
  4. Note that preprint now lacks a "First Author" in moderator dashboard.

Expected behavior
Name of the set First Author should display in "First Author" field.

Error msg from an author reorder attempt

>>> works = Preprint(2819)
>>> broke = Preprint(2825)
>>> works.preprintauthor_set.first()
<PreprintAuthor: Oliver Lamb linked to >
>>> broke.preprintauthor_set.first()
<PreprintAuthor: None None linked to >
>>> broke = Preprint(2823)
>>> broke.preprintauthor_set.first()
<PreprintAuthor: Alainna TW linked to >
>>> works.preprintauthor_set.first().full_name
'Oliver Lamb'
>>> broke.preprintauthor_set.first().full_name
'Alainna TW'
>>> 

Screenshots
image

@alainna alainna added the bug Something's not working label Nov 3, 2021
@alainna alainna changed the title Preprints: First author is not displaying in dashboard view Preprints: Newly added first authors are not displaying in dashboard view Nov 3, 2021
tingletech added a commit to tingletech/janeway that referenced this issue Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working
Projects
None yet
Development

No branches or pull requests

1 participant