Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords in Janeway should allow a set sort order #2187

Closed
alainna opened this issue May 6, 2021 · 3 comments
Closed

Keywords in Janeway should allow a set sort order #2187

alainna opened this issue May 6, 2021 · 3 comments
Assignees
Labels
new feature A new thing that doesn't exist yet
Milestone

Comments

@alainna
Copy link
Contributor

alainna commented May 6, 2021

Is your feature request related to a problem? Please describe.
As a submitting author or editor/manager, I expect that keywords will display per the sort order that I have assigned them.

Janeway version
Janeway Preprints

Manager changes keyword order, it does not save

Steps to reproduce

  1. In manager view, find preprint with 3+ keywords
  2. Change display order of keywords e.g. KeywordB, KeyboardC, KeywordA
  3. Save

Expected

Keywords display as KeywordB, KeyboardC, KeywordA

Actual

Keywords display as KeywordA, KeywordB, KeyboardC

Manager removes all keywords, saves, add mix of new and old keywords in different order; keyword order does not save

Steps to reproduce

  1. In manager view, find preprint with 3+ keywords
  2. Remove all keywords
  3. Save
  4. Add keywords as: NewKeywordD, OldKeywordB, NewKeywordE, OldKeywordC
  5. Save

Expected

Keywords display as NewKeywordD, OldKeywordB, NewKeywordE, OldKeywordC

Actual

Keywords display as OldKeywordB, OldKeywordC, NewKeywordD, NewKeywordE

image

@alainna alainna added the new feature A new thing that doesn't exist yet label May 6, 2021
@mauromsl
Copy link
Member

mauromsl commented May 6, 2021

Thanks for the report @alainna

We implented this behaviour in Janeway 1.3.9 already: #2056
Once we update the preprint-remodel branch and mergeit into master, all keywords should preserve the order they were inserted on.

I'll leave the issue open and test it once we are closer to the official release of Preprints (1.4.1)

@mauromsl mauromsl modified the milestones: 1.4.2, 1.4.1 May 6, 2021
@alainna
Copy link
Contributor Author

alainna commented May 6, 2021

Lovely, thanks @mauromsl ! I've added it to our local card so we can track it with the update

@mauromsl
Copy link
Member

closed by #2056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new thing that doesn't exist yet
Projects
None yet
Development

No branches or pull requests

3 participants