Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch_language setting wrongfully flagged as translatable #2160

Closed
mauromsl opened this issue Apr 23, 2021 · 0 comments · Fixed by #2272
Closed

switch_language setting wrongfully flagged as translatable #2160

mauromsl opened this issue Apr 23, 2021 · 0 comments · Fixed by #2272
Labels
bug Something's not working
Milestone
v1.4

Comments

@mauromsl
Copy link
Member

Describe the bug
The switch_language setting is flagged as translatable, despite being a boolean

Janeway version
v1.3.9

Expected behavior
The setting should not be flagged as translatable
A migration will be required to fix the setting as installed in all current journals
@mauromsl mauromsl added the bug Something's not working label Apr 23, 2021
@mauromsl mauromsl added this to the 1.4 milestone Apr 23, 2021
ajrbyers added a commit that referenced this issue May 10, 2021
@ajrbyers
Closes #2170. Closes #2160
0d9eb46
ajrbyers added a commit that referenced this issue Jun 23, 2021
@ajrbyers
Closes #2170. Closes #2160
e5af12a
ajrbyers added a commit that referenced this issue Jun 28, 2021
@ajrbyers
Closes #2160
d0c3f14
@ajrbyers ajrbyers mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something's not working
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

1 4 working branch openlibhums/janeway
1 participant
@mauromsl