Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-remove erroneous formatting for abstracts in metadata #1481

Closed
rhb123 opened this issue Mar 26, 2020 · 8 comments · Fixed by #3446 or #3983
Closed

Auto-remove erroneous formatting for abstracts in metadata #1481

rhb123 opened this issue Mar 26, 2020 · 8 comments · Fixed by #3446 or #3983
Assignees
Labels
bug Something's not working size L Large

Comments

@rhb123
Copy link
Collaborator

rhb123 commented Mar 26, 2020

Describe the bug
At present, even when using plain text editors to paste metadata into the abstract field, this leaves a lot of invisible code junk which messes up the formatting, meaning that it needs to be fixed by going into the code manually. This is particularly time consuming across an issue, at which this needs to be fixed individually for several articles.

Expected behavior
An auto-formatter would be good that strips out all surplus / weird formatting would be great as it would save a lot of time doing these individually.

Thanks for your help

@rhb123 rhb123 added the bug Something's not working label Mar 26, 2020
@ajrbyers ajrbyers added this to the 1.5 - YAR milestone Dec 14, 2020
@ajrbyers
Copy link
Member

Clean paste available in new version of Django Summernote.

@ajrbyers ajrbyers removed this from the 1.6 - YAR milestone Jun 15, 2021
@joemull joemull added this to v1.4.3 May 24, 2022
@joemull joemull moved this to Todo in v1.4.3 May 24, 2022
@joemull
Copy link
Member

joemull commented May 24, 2022

Provisionally added to 1.4.3 as a reminder to take care of the Summernote formatting issues that are a persistent frustration for many users

@ajrbyers
Copy link
Member

Another option for this one: Bleach Field. It can be used with summernote.

@ajrbyers ajrbyers self-assigned this May 24, 2022
@ajrbyers
Copy link
Member

Sadly, this issue will need to wait until 1.5 as bleach, which I think is the best solution for this, doesn't work on django 1.11.

@ajrbyers ajrbyers removed their assignment Jun 16, 2022
@ajrbyers ajrbyers removed this from v1.4.3 Jun 16, 2022
@joemull
Copy link
Member

joemull commented Jul 15, 2022

It will be important to retain italicization by default so that titles of works retain italics.

@ajrbyers
Copy link
Member

It will be important to retain italicization by default so that titles of works retain italics.

Using bleach will allow us to flexibly determine which elements are and which aren't allowed. They can bet set at the global level and then tweaked for individual fields that require different elements.

mauromsl added a commit to mauromsl/janeway that referenced this issue Mar 12, 2024
ajrbyers pushed a commit that referenced this issue Mar 12, 2024
ajrbyers pushed a commit that referenced this issue Mar 12, 2024
ajrbyers pushed a commit that referenced this issue Mar 12, 2024
ajrbyers pushed a commit that referenced this issue Mar 12, 2024
ajrbyers pushed a commit that referenced this issue Mar 12, 2024
ajrbyers pushed a commit that referenced this issue Mar 12, 2024
ajrbyers pushed a commit that referenced this issue Mar 12, 2024
@mauromsl
Copy link
Member

closed by #3983

@github-project-automation github-project-automation bot moved this from 📝 PR Submitted to ✅ Done in v1.5.1 Archer Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working size L Large
Projects
No open projects
Status: Done
4 participants