#3478 addreses inline review comments.

openlibhums · Sep 11, 2024 · 39ae4b4 · 39ae4b4
1 parent 6548d48
commit 39ae4b4
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/src/static/admin/css/admin.css b/src/static/admin/css/admin.css
@@ -825,19 +825,19 @@ ul.menu {
 
 .key-value-pair {
   font-family: "Open Sans", sans-serif;
-  margin-bottom: 20px;
+  margin-bottom: 1.25rem;
 }
 
 .key-value-pair.key-above .key {
-  font-size: 16px;
+  font-size: 1rem;
   line-height: 1.4;
   text-align: left;
   color: #696969;
-  margin-bottom: 5px;
+  margin-bottom: 0.31rem;
 }
 
 .key-value-pair.key-above .value {
-  font-size: 18px;
+  font-size: 1.125rem;
   line-height: 1.4;
   text-align: left;
 }

diff --git a/src/templates/admin/elements/layout/key_value_above.html b/src/templates/admin/elements/layout/key_value_above.html
@@ -12,7 +12,7 @@
     {% elif render_line_breaks %}
       {{ value|linebreaksbr|default_if_none:"No value supplied" }}
     {% else %}
-      {{ value|default_if_none:"No value supplied" }}
+      {{ value|default:"No value supplied" }}
     {% endif %}
   </div>
 </div>
diff --git a/src/templates/admin/repository/submit/authors.html b/src/templates/admin/repository/submit/authors.html
@@ -100,7 +100,7 @@ <h2>{% trans 'Authors' %}</h2>
                     <p>{% trans 'Once you have added all of your authors you can complete this stage.' %}</p>
                     <form method="POST">
                         {% csrf_token %}
-                        <button name="complete" class="button">{% trans 'Complete Step 2 of 3' %}</button>
+                        <button name="complete" class="button">{% trans 'Complete Step 2 of 4' %}</button>
                     </form>
                 </div>
             </div>

diff --git a/src/templates/admin/repository/submit/files.html b/src/templates/admin/repository/submit/files.html
@@ -86,7 +86,7 @@ <h2>Supplementary File</h2>
                 </div>
                     <form method="POST">
                         {% csrf_token %}
-                        <button name="complete" class="button">{% trans 'Complete Step 3 of 3' %}</button>
+                        <button name="complete" class="button">{% trans 'Complete Step 3 of 4' %}</button>
                     </form>
             </div>
         </div>

diff --git a/src/templates/admin/repository/submit/review.html b/src/templates/admin/repository/submit/review.html
@@ -128,7 +128,7 @@ <h2>Complete Submission</h2>
           <form method="POST">
             {% csrf_token %}
             <button name="complete" class="button">
-              Submit {{ request.repository.object_name }}
+              Complete Step 4 of 4 and Submit {{ request.repository.object_name }}
             </button>
           </form>
         </div>

diff --git a/src/templates/admin/repository/submit/start.html b/src/templates/admin/repository/submit/start.html
@@ -89,7 +89,7 @@ <h2>{% trans "Metadata" %}</h2>
                             <div class="row">
                                 <div class="large-12 columns">
                                     <button class="button pull-right" type="submit" name="start_submission"><i
-                                            class="fa fa-check">&nbsp;</i>{% trans "Complete Step 1 of 3" %}
+                                            class="fa fa-check">&nbsp;</i>{% trans "Complete Step 1 of 4" %}
                                     </button>
                                 </div>
                             </div>