#4141 fixes is_staff and is_active setting

openlibhums · Apr 30, 2024 · 202b214 · 202b214
1 parent 8109c54
commit 202b214
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/src/api/tests/test_api.py b/src/api/tests/test_api.py
@@ -18,25 +18,19 @@ def setUpTestData(cls):
             roles=['author'],
             journal=cls.journal,
             is_staff=True,
-            atrrs={
-                'is_active': True,
-            }
+            is_active=True,
         )
         cls.editor = helpers.create_user(
             username='[email protected]',
             roles=['editor'],
             journal=cls.journal,
-            atrrs={
-                'is_active': True,
-            }
+            is_active=True,
         )
         cls.average_user = helpers.create_user(
             '[email protected]',
             roles=['author'],
             journal=cls.journal,
-            attrs={
-                'is_active': True,
-            }
+            is_active=True,
         )
         helpers.create_roles(
             ['journal-manager'],

diff --git a/src/utils/testing/helpers.py b/src/utils/testing/helpers.py
@@ -30,7 +30,7 @@
 from cms import models as cms_models
 
 
-def create_user(username, roles=None, journal=None, is_staff=False, **attrs):
+def create_user(username, roles=None, journal=None, **attrs):
     """
     Creates a user with the specified permissions.
     :username: A unique username to set the user username and email
@@ -64,8 +64,6 @@ def create_user(username, roles=None, journal=None, is_staff=False, **attrs):
     for attr, value in attrs.items():
         setattr(user, attr, value)
 
-    user.is_staff = is_staff
-
     user.save()
 
     return user