#2168: Fix cardinality error due to group by assignment

openlibhums · Apr 27, 2021 · 1f11c27 · 1f11c27
1 parent 2f39b97
commit 1f11c27
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/review/logic.py b/src/review/logic.py
@@ -57,6 +57,9 @@ def get_reviewer_candidates(article, user=None):
     rating_average = models.ReviewerRating.objects.filter(
         assignment__article__journal=article.journal,
         assignment__reviewer=OuterRef("id"),
+    ).values(
+        # Without this .values call, results are grouped by assignment...
+        "assignment__article__journal",
     ).annotate(
         rating_average=Avg("rating"),
     ).values("rating_average")