Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3491 updates as ReviewForm's slug field has now been removed. #83

Merged
merged 2 commits into from
Dec 12, 2023
Merged

#3491 updates as ReviewForm's slug field has now been removed. #83

merged 2 commits into from
Dec 12, 2023

Conversation

ajrbyers
Copy link
Member

@joemull joemull requested a review from mauromsl May 19, 2023 12:32
mauromsl
mauromsl requested changes May 19, 2023
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change request in line. Though it is a bit of an edge-case now that there is a signal handling default form creation. It is probably still worth alerting when no forms are available

@ajrbyers
Copy link
Member Author

I've made the requested changes, but this included tweaking core so this PR is now reliant on: openlibhums/janeway#3824

@mauromsl mauromsl merged commit a81aea4 into master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl approved these changes

@joemull joemull joemull approved these changes

Assignees

@ajrbyers ajrbyers

Labels
None yet
Projects
No open projects
v1.5.1 Archer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajrbyers @mauromsl @joemull