Skip to content

Commit

Permalink
#3491 updates as ReviewForm's slug field has now been removed.
Browse files Browse the repository at this point in the history
  • Loading branch information
ajrbyers authored and mauromsl committed Dec 12, 2023
1 parent a612bc6 commit 12c2335
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions ojs/importers.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,9 @@ def import_review_data(article_dict, article, client):

# Attempt to get the default review form
try:
form = review_models.ReviewForm.objects.get(
form = review_models.ReviewForm.objects.filter(
journal=article.journal,
slug="default-form",
)
).first()
except review_models.ReviewForm.DoesNotExit:
logger.error(
'You must have at least one review form for the journal before'
Expand Down
5 changes: 3 additions & 2 deletions ojs/ojs3_importers.py
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,9 @@ def import_article_galleys(article, publication, journal, client):
def import_reviews(client, article, article_dict):
create_workflow_log(article, sm_models.STAGE_UNASSIGNED)
logger.info("Importing peer reviews")
default_form = review_models.ReviewForm.objects.get(
slug="default-form", journal=article.journal)
default_form = review_models.ReviewForm.objects.filter(
journal=article.journal,
).first()
for round_dict in article_dict["reviewRounds"]:
round, c = review_models.ReviewRound.objects.get_or_create(
article=article,
Expand Down
1 change: 0 additions & 1 deletion utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,6 @@ def generate_review_forms(request):
default_review_form = review_models.ReviewForm.objects.create(
journal=journal,
name='Default Form',
slug='default-form',
intro='Please complete the form below.',
thanks='Thank you for completing the review.'
)
Expand Down

0 comments on commit 12c2335

Please sign in to comment.