Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty tiles to avoid endless loop #16519

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Ignore empty tiles to avoid endless loop #16519

merged 3 commits into from
Dec 31, 2024

Conversation

mike-000
Copy link
Contributor

@mike-000 mike-000 commented Dec 30, 2024 •
edited
Loading

Fixes #16493

Marking as ready for review as it works and does not break anything, but I do not know if it could be tested any further.

@github-actions GitHub Actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-16519--ol-site.netlify.app/.

@mike-000 mike-000 marked this pull request as ready for review December 30, 2024 14:53
ahocevar
ahocevar reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same code is found in ol/renderer/webgl/TileLayer.js and ol/renderer/webgl/TileLayerBase.js. I think the change should be made there as well.

Regarding tests, I don't have a good idea either. As I said, I don't know why that check for ReprojTile and ReprojDataTile was added in the first place.

@mike-000
Copy link
Contributor Author

mike-000 commented Dec 30, 2024 •
edited
Loading

The same code is found in ol/renderer/webgl/TileLayer.js and ol/renderer/webgl/TileLayerBase.js.

The code in ol/renderer/webgl/TileLayer.js is for getData() but it does make sense to immediately return null for any empty tile. There is no similar check for canvas tile layers, perhaps it should be added?

@ahocevar ahocevar merged commit 076b7ab into openlayers:main Dec 31, 2024
8 checks passed
@ahocevar
Copy link
Member

Thanks, @mike-000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahocevar ahocevar ahocevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endless animation loop when passing wrapX to WMTS source with non-global projection
2 participants
@mike-000 @ahocevar