Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make name and version arguments mandatory #295

Conversation

alcarney
Copy link
Collaborator

@alcarney alcarney commented Dec 3, 2022

Description (e.g. "Related to ...", etc.)

I think in #274 we said we wanted to make the name and version arguments to a LanguageServer object mandatory?
This PR removes the warning and default arguments meaning they now have to be provided by the language server author.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@alcarney alcarney force-pushed the mandatory-server-name branch from 0a3f681 to c26b24d Compare December 3, 2022 18:19
@tombh tombh merged commit dd484ab into openlawlibrary:v1-lsprotocol-breaking-alpha Dec 3, 2022
@tombh
Copy link
Collaborator

tombh commented Dec 3, 2022

(Saw you fix the test as I was typing 😏)

Well remembered! The v1 release is the perfect moment to include this.

@alcarney alcarney deleted the mandatory-server-name branch December 3, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants