Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding kind field to resource file operation types #177

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Adding kind field to resource file operation types #177

merged 2 commits into from
Apr 23, 2021

Conversation

anu-ka
Copy link
Contributor

@anu-ka anu-ka commented Apr 23, 2021 •
edited by danixeee
Loading

Adds kind filed to CreateFile, RenameFile and DeleteFile

Closes #176 . Missing kind causes error in VS Code when renaming packages.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee self-requested a review April 23, 2021 09:01
@danixeee danixeee added the bug Something isn't working label Apr 23, 2021
danixeee
danixeee approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@danixeee danixeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

@danixeee danixeee merged commit 11096f7 into openlawlibrary:master Apr 23, 2021
brettcannon pushed a commit to brettcannon/pygls that referenced this pull request Apr 30, 2021
@anu-ka @brettcannon
Adding kind field to resource file operation types (openlawlibrary#177)
9039dd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danixeee danixeee danixeee approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateFile, RenameFile, and DeleteFile missing required kind field
2 participants
@anu-ka @danixeee