Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pod not ready quickly when add not ready key #980

Merged
merged 1 commit into from
May 20, 2022

Conversation

veophi
Copy link
Member

@veophi veophi commented May 20, 2022

Signed-off-by: mingzhou.swx [email protected]

Ⅰ. Describe what this PR does

Make pod not ready directly when add not ready key

Ⅱ. Does this pull request fix one issue?

patch for #979

@kruise-bot kruise-bot requested review from FillZpp and furykerry May 20, 2022 09:07
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label May 20, 2022
@veophi veophi force-pushed the lifecycle-patch branch from 7fb9e8f to 346bf4d Compare May 20, 2022 09:22
@kruise-bot kruise-bot added size/L size/L: 100-499 and removed size/XS size/XS: 0-9 labels May 20, 2022
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 0434cfa into openkruise:master May 20, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: mingzhou.swx <[email protected]>

Co-authored-by: mingzhou.swx <[email protected]>
Signed-off-by: Liu Zhenwei <[email protected]>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants