Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DeepCopy for some specific cache list #916

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Mar 2, 2022

Signed-off-by: FillZpp [email protected]

Ⅰ. Describe what this PR does

  1. A custom delegating client has been added, which supports to use custom cache reader with DisableDeepCopy option.
  2. Disable DeepCopy for some specific cache list.

Ⅱ. Does this pull request fix one issue?

fixes #872

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Mar 2, 2022
@FillZpp FillZpp force-pushed the disable-deepcopy-for-specific-resources branch from 6d215a5 to 0663501 Compare March 3, 2022 03:32
@codecov-commenter
Copy link

Codecov Report

Merging #916 (0663501) into master (7722528) will decrease coverage by 0.11%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   49.37%   49.26%   -0.12%     
==========================================
  Files         119      119              
  Lines       11102    11102              
==========================================
- Hits         5482     5469      -13     
- Misses       4786     4794       +8     
- Partials      834      839       +5     
Flag Coverage Δ
unittests 49.26% <16.66%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_controller.go 52.85% <0.00%> (ø)
pkg/controller/cloneset/utils/cloneset_utils.go 0.00% <0.00%> (ø)
pkg/controller/sidecarset/sidecarset_processor.go 70.00% <0.00%> (ø)
pkg/util/imagejob/imagejob_reader.go 52.55% <0.00%> (ø)
pkg/webhook/pod/mutating/sidecarset.go 73.83% <0.00%> (ø)
pkg/util/refmanager/ref_manager.go 40.17% <100.00%> (ø)
...roller/uniteddeployment/uniteddeployment_update.go 74.15% <0.00%> (-6.75%) ⬇️
...teddeployment/uniteddeployment_controller_utils.go 63.63% <0.00%> (-4.55%) ⬇️
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.53%) ⬇️
...er/uniteddeployment/uniteddeployment_controller.go 70.44% <0.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722528...0663501. Read the comment docs.

@FillZpp FillZpp force-pushed the disable-deepcopy-for-specific-resources branch 2 times, most recently from cb6cac0 to c0ee58e Compare March 3, 2022 12:36
@kruise-bot kruise-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels Mar 3, 2022
@FillZpp FillZpp force-pushed the disable-deepcopy-for-specific-resources branch 6 times, most recently from af08ec0 to 7211893 Compare March 8, 2022 03:43
@FillZpp FillZpp force-pushed the disable-deepcopy-for-specific-resources branch from 7211893 to d3fac17 Compare March 8, 2022 05:28
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Mar 8, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FillZpp FillZpp merged commit 2953c6c into openkruise:master Mar 8, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Disable cache DeepCopy to reduce memory usage for kruise-manager
4 participants