Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Apply SidecarSet Update Strategy In The Injection Phase #789

Conversation

a630140621
Copy link

@a630140621 a630140621 commented Oct 31, 2021

Signed-off-by: lovecrazy [email protected]

Ⅰ. Describe what this PR does

Add a proposal to explain how to implement sidecarset update strategy in the injection phase

Ⅱ. Does this pull request fix one issue?

fixes #783

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp October 31, 2021 09:54
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign furykerry
You can assign the PR to them by writing /assign @furykerry in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @a630140621! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Oct 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #789 (8afde5f) into master (9a0879c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #789   +/-   ##
=======================================
  Coverage   47.82%   47.82%           
=======================================
  Files         118      118           
  Lines       10856    10856           
=======================================
  Hits         5192     5192           
  Misses       4865     4865           
  Partials      799      799           
Flag Coverage Δ
unittests 47.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0879c...8afde5f. Read the comment docs.

@stale
Copy link

stale bot commented Jan 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 31, 2022
@FillZpp FillZpp removed the wontfix This will not be worked on label Jan 31, 2022
@stale
Copy link

stale bot commented May 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 1, 2022
@stale stale bot closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support SidecarSet update strategy when pod recreate or inject
4 participants