changed the scorecard badge link to the standard format #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @harshitasao! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
+ Coverage 47.91% 49.40% +1.49%
==========================================
Files 162 183 +21
Lines 23491 18997 -4494
==========================================
- Hits 11256 9386 -1870
+ Misses 11014 8386 -2628
- Partials 1221 1225 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
thanks for your patch. however when we visit the new link, it is not working and shows the following error Status code: undefinedundefined" |
|
plz squash the commits into one |
|
Hi, I checked this on my branch and it's working correctly, showing a score of 8.4. |
…he domain Signed-off-by: harshitasao <[email protected]>
harshitasao
force-pushed
the
scorecard-badge-link
branch
from
29eea39 to
01285d1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hantmac
added a commit
to hantmac/kruise
that referenced
this pull request
Jul 18, 2024
Signed-off-by: hantmac <[email protected]> more docs Signed-off-by: hantmac <[email protected]> fix mdl ci Signed-off-by: hantmac <[email protected]> complete the proposal Signed-off-by: hantmac <[email protected]> fix Signed-off-by: hantmac <[email protected]> update Signed-off-by: hantmac <[email protected]> fix typo Signed-off-by: hantmac <[email protected]> Bump crate-ci/typos from 1.22.9 to 1.23.1 (openkruise#1658) Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.22.9...v1.23.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump actions/upload-artifact from 4.3.3 to 4.3.4 (openkruise#1659) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> changed the scorecard badge link to the standard format and updated the domain (openkruise#1657) Signed-off-by: harshitasao <[email protected]>
hantmac
added a commit
to hantmac/kruise
that referenced
this pull request
Jul 18, 2024
Signed-off-by: hantmac <[email protected]> more docs Signed-off-by: hantmac <[email protected]> fix mdl ci Signed-off-by: hantmac <[email protected]> complete the proposal Signed-off-by: hantmac <[email protected]> fix Signed-off-by: hantmac <[email protected]> update Signed-off-by: hantmac <[email protected]> fix typo Signed-off-by: hantmac <[email protected]> Bump crate-ci/typos from 1.22.9 to 1.23.1 (openkruise#1658) Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.22.9...v1.23.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump actions/upload-artifact from 4.3.3 to 4.3.4 (openkruise#1659) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> changed the scorecard badge link to the standard format and updated the domain (openkruise#1657) Signed-off-by: harshitasao <[email protected]> fix typo Signed-off-by: hantmac <[email protected]>
kruise-bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
more docs fix mdl ci complete the proposal fix update fix typo Bump crate-ci/typos from 1.22.9 to 1.23.1 (#1658) Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.22.9...v1.23.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Bump actions/upload-artifact from 4.3.3 to 4.3.4 (#1659) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... changed the scorecard badge link to the standard format and updated the domain (#1657) fix typo Signed-off-by: hantmac <[email protected]>
furykerry
pushed a commit
to furykerry/kruise
that referenced
this pull request
Feb 8, 2025
…he domain (openkruise#1657) Signed-off-by: harshitasao <[email protected]>
furykerry
pushed a commit
to furykerry/kruise
that referenced
this pull request
Feb 8, 2025
…ise#1520) more docs fix mdl ci complete the proposal fix update fix typo Bump crate-ci/typos from 1.22.9 to 1.23.1 (openkruise#1658) Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.22.9...v1.23.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Bump actions/upload-artifact from 4.3.3 to 4.3.4 (openkruise#1659) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... changed the scorecard badge link to the standard format and updated the domain (openkruise#1657) fix typo Signed-off-by: hantmac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Changes the scorecard badge link from old format to the Standard human-readable OpenSSF Scorecard Report.
Ⅱ. Does this pull request fix one issue?
N/A
Ⅲ. Describe how to verify it
N/A
Ⅳ. Special notes for reviews
N/A