pod probe marker apis #1073

zmberg · 2022-09-13T02:53:57Z

Signed-off-by: liheng.zms [email protected]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

codecov-commenter · 2022-09-13T03:05:38Z

Codecov Report

Merging #1073 (2901247) into master (4edba53) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
+ Coverage   50.24%   50.26%   +0.01%     
==========================================
  Files         126      126              
  Lines       17839    17839              
==========================================
+ Hits         8964     8967       +3     
+ Misses       7887     7884       -3     
  Partials      988      988

Flag	Coverage Δ
unittests	`50.26% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/daemonset/daemonset_update.go	`58.28% <0.00%> (+0.92%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

furykerry

/lgtm

FillZpp · 2022-09-13T04:12:58Z

apis/apps/v1alpha1/node_pod_probe_types.go

+	// pod namespace
+	Namespace string `json:"namespace,omitempty"`
+	// pod uid
+	Uid string `json:"uid"`


FillZpp · 2022-09-13T05:04:36Z

apis/apps/v1alpha1/node_pod_probe_types.go

+type ProbeState string
+
+const (
+	ProbeTrue    ProbeState = "True"


Succeeded/Failed should be more intuitive than True/False as probe state.

The probe state feeds back to the POD condition, which is also viewed by the user, so it is better to keep the probe state consistent with the condition type

FillZpp · 2022-09-13T05:06:02Z

apis/apps/v1alpha1/pod_probe_marker_types.go

+	MarkerPolicy []ProbeMarkerPolicy `json:"markerPolicy,omitempty"`
+}
+
+type ContainerProbeSpec struct {


Why not just use v1.Probe?

FillZpp · 2022-09-13T05:06:31Z

apis/apps/v1alpha1/node_pod_probe_types.go

+	// pod namespace
+	Namespace string `json:"namespace,omitempty"`
+	// pod uid
+	Uid string `json:"uid"`


furykerry

/lgtm

Signed-off-by: liheng.zms <[email protected]>

FillZpp · 2022-09-13T10:48:41Z

/lgtm

Signed-off-by: liheng.zms <[email protected]>

furykerry · 2022-09-14T02:05:59Z

/lgtm

FillZpp · 2022-09-14T03:12:31Z

/approve

kruise-bot · 2022-09-14T03:12:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [FillZpp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* pod probe marker apis Signed-off-by: liheng.zms <[email protected]> * fix statefulset truncateHistory panic Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> Signed-off-by: Liu Zhenwei <[email protected]>

Signed-off-by: peng.xin <[email protected]> optimize workloadspread when suitable subset maxReplicas is niil (openkruise#1066) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> Optimize performance of LabelSelector conversion (openkruise#1068) Signed-off-by: FillZpp <[email protected]> Signed-off-by: FillZpp <[email protected]> Support timezone for AdvancedCronJob (openkruise#1070) Signed-off-by: FillZpp <[email protected]> Signed-off-by: FillZpp <[email protected]> ignore if pod condition has been updated (openkruise#1074) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> pod probe marker apis (openkruise#1073) * pod probe marker apis Signed-off-by: liheng.zms <[email protected]> * fix statefulset truncateHistory panic Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> pod probe marker controller (openkruise#1075) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> consider whether patch field is matched when assign existing pods to subset (openkruise#1083) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> pod probe marker webhook (openkruise#1078) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> sidecarset support pods ns(kube-system, kube-public) (openkruise#1084) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> pod probe marker proposal (openkruise#1053) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> node pod probe daemon (openkruise#1077) Signed-off-by: liheng.zms <[email protected]> sidecarset support patch pod metadata proposal (openkruise#993) Signed-off-by: liheng.zms <[email protected]> Support predownload image in ads (openkruise#1057) Signed-off-by: Abner <[email protected]> * support predownload image for ads Add PreDownloadImageForDaemonSetUpdate featureGate (openkruise#1093) Signed-off-by: FillZpp <[email protected]> Signed-off-by: FillZpp <[email protected]> Add changelog for v1.3.0 (openkruise#1092) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> fix sidecarset inject annotations abnormal (openkruise#1101) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> fix InPlaceUpdateEnvFromMetadata bug (openkruise#1108) Co-authored-by: 郭已钦 <[email protected]> support uniteddeployment persistentVolumeClaimRetentionPolicy inherit from advancestatefulset template (openkruise#1110) Signed-off-by: cheyuexian <[email protected]> Signed-off-by: cheyuexian <[email protected]> Co-authored-by: cheyuexian <[email protected]> Add PreNormal Lifecycle Hook for CloneSet (openkruise#1071) * add pre-normal(pre-available) hook Signed-off-by: mingzhou.swx <[email protected]> * add pre-normal(pre-available) hook Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> partition support float percent (openkruise#1124) Signed-off-by: shiyan2016 <[email protected]> Signed-off-by: shiyan2016 <[email protected]> improve error hanlding of inplace update env from metadata (openkruise#1125) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> pub support to configure Evict,Delete,Update Operation (openkruise#1126) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> feat: add watch whitelist feat: add watch whitelist add watch whitelist check add dynamic watch option feat: add persistent annotations format feat: add pps support custom workload Signed-off-by: peng.xin <[email protected]> fix: nodeSelector and nodeAffinity have not been modified Signed-off-by: peng.xin <[email protected]> fix: error string Signed-off-by: peng.xin <[email protected]> fix: error string Signed-off-by: peng.xin <[email protected]> fix: goimports Signed-off-by: peng.xin <[email protected]> refactor: refactoring ersistentPodAnnotations type Signed-off-by: peng.xin <[email protected]> - add statefulet group check - modify the pod create processing logic Signed-off-by: peng.xin <[email protected]> refactor: pps watch of whitelist workload Signed-off-by: peng.xin <[email protected]> fix: add statefulsetlike's pod controller Signed-off-by: peng.xin <[email protected]>

* pod probe marker apis * fix statefulset truncateHistory panic

kruise-bot requested review from FillZpp and furykerry September 13, 2022 02:54

kruise-bot added the size/XXL label Sep 13, 2022

zmberg force-pushed the pod-probe-marker-apis branch 2 times, most recently from fa68db9 to d1b885e Compare September 13, 2022 03:36

furykerry reviewed Sep 13, 2022

View reviewed changes

kruise-bot assigned furykerry Sep 13, 2022

kruise-bot added the lgtm label Sep 13, 2022

FillZpp reviewed Sep 13, 2022

View reviewed changes

zmberg force-pushed the pod-probe-marker-apis branch from d1b885e to a364501 Compare September 13, 2022 06:10

kruise-bot removed the lgtm label Sep 13, 2022

zmberg force-pushed the pod-probe-marker-apis branch 2 times, most recently from f64c6b3 to fa3fda1 Compare September 13, 2022 07:55

furykerry reviewed Sep 13, 2022

View reviewed changes

kruise-bot added the lgtm label Sep 13, 2022

pod probe marker apis

3b5c900

Signed-off-by: liheng.zms <[email protected]>

zmberg force-pushed the pod-probe-marker-apis branch from fa3fda1 to 3b5c900 Compare September 13, 2022 10:18

kruise-bot removed the lgtm label Sep 13, 2022

kruise-bot assigned FillZpp Sep 13, 2022

kruise-bot added lgtm and removed lgtm labels Sep 13, 2022

fix statefulset truncateHistory panic

ddb685a

Signed-off-by: liheng.zms <[email protected]>

zmberg force-pushed the pod-probe-marker-apis branch from 058a6ba to ddb685a Compare September 14, 2022 02:03

kruise-bot added the lgtm label Sep 14, 2022

kruise-bot added the approved label Sep 14, 2022

kruise-bot merged commit 16277db into openkruise:master Sep 14, 2022

zmberg deleted the pod-probe-marker-apis branch September 14, 2022 03:14

ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024

pod probe marker apis (openkruise#1073)

9434e1c

* pod probe marker apis * fix statefulset truncateHistory panic

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pod probe marker apis #1073

pod probe marker apis #1073

zmberg commented Sep 13, 2022

codecov-commenter commented Sep 13, 2022

furykerry left a comment

FillZpp Sep 13, 2022

FillZpp Sep 13, 2022

zmberg Sep 13, 2022

FillZpp Sep 13, 2022

FillZpp Sep 13, 2022

furykerry left a comment

FillZpp commented Sep 13, 2022

furykerry commented Sep 14, 2022

FillZpp commented Sep 14, 2022

kruise-bot commented Sep 14, 2022

pod probe marker apis #1073

pod probe marker apis #1073

Conversation

zmberg commented Sep 13, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

codecov-commenter commented Sep 13, 2022

Codecov Report

furykerry left a comment

Choose a reason for hiding this comment

FillZpp Sep 13, 2022

Choose a reason for hiding this comment

FillZpp Sep 13, 2022

Choose a reason for hiding this comment

zmberg Sep 13, 2022

Choose a reason for hiding this comment

FillZpp Sep 13, 2022

Choose a reason for hiding this comment

FillZpp Sep 13, 2022

Choose a reason for hiding this comment

furykerry left a comment

Choose a reason for hiding this comment

FillZpp commented Sep 13, 2022

furykerry commented Sep 14, 2022

FillZpp commented Sep 14, 2022

kruise-bot commented Sep 14, 2022