Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Optimizing Pod SidecarSet webhook performance #1546

Closed
zmberg opened this issue Mar 28, 2024 · 1 comment
Closed

[feature request] Optimizing Pod SidecarSet webhook performance #1546

zmberg opened this issue Mar 28, 2024 · 1 comment
Assignees
@zmberg @ls-2018
Labels
kind/feature-request kind/good-idea Good Idea

Comments

@zmberg
Copy link
Member

zmberg commented Mar 28, 2024

What would you like to be added:
The current Pod sidecarSet webhook lists all the SidecarSet resources of the cluster each time, which in turn consumes a lot of resources. However, SidecarSet does have a spec.namespace field, as it can be filtered one layer at a time based on changing the field.

In addition, the sidecarset RegisterFieldIndexes method can be added to improve the performance of List spec.namespace.

Why is this needed:
@zmberg zmberg assigned FillZpp and zmberg and unassigned FillZpp Mar 28, 2024
@zmberg zmberg added the kind/good-idea Good Idea label Mar 28, 2024
@ls-2018
Copy link
Member

ls-2018 commented Mar 28, 2024

/assign @ls-2018

ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
c4f473d 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
51d4e52 
Signed-off-by: acejilam <[email protected]>
@ls-2018 ls-2018 mentioned this issue Mar 28, 2024
Merged
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
983fdd8 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
9a8edbe 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
8e01623 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
650b7a3 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
27a49ea 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
4298d8b 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Mar 28, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
d9ee8fd 
Signed-off-by: acejilam <[email protected]>
ls-2018 added a commit to ls-2018/kruise that referenced this issue Apr 2, 2024
@ls-2018
feature: Optimizing Pod SidecarSet webhook performance openkruise#1546
125f1dd 
Signed-off-by: acejilam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmberg zmberg

@ls-2018 ls-2018

Labels
kind/feature-request kind/good-idea Good Idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@furykerry @FillZpp @zmberg @ls-2018