Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ratesb_python: Rate Law Analysis for SBML and Antimony #7268

Closed
editorialbot opened this issue Sep 23, 2024 · 53 comments
Closed
Assignees
Labels
Dockerfile pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 23, 2024

Submitting author: @longxf21 (Longxuan Fan)
Repository: https://github.com/sys-bio/ratesb_python
Branch with paper.md (empty if default branch):
Version: v0.2.6
Editor: @RMeli
Reviewers: @ayush9pandey, @dilawar
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f12fdb3eb5db0349d08be12b9a337147"><img src="https://joss.theoj.org/papers/f12fdb3eb5db0349d08be12b9a337147/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f12fdb3eb5db0349d08be12b9a337147/status.svg)](https://joss.theoj.org/papers/f12fdb3eb5db0349d08be12b9a337147)

Author instructions

Thanks for submitting your paper to JOSS @longxf21. Currently, there isn't a JOSS editor assigned to your paper.

@longxf21 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Sep 23, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (2478.1 files/s, 113993.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          11            351            500           1669
XML                             62              8             10            686
reStructuredText                 8            122             98            278
JSON                             8              1              0            274
Markdown                         2             79              0            220
TeX                              1              3              0             50
YAML                             2              7              0             44
DOS Batch                        1              8              1             26
TOML                             1              0              0             21
Dockerfile                       1              5              7             20
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            98            588            623           3297
-------------------------------------------------------------------------------

Commit count by author:

    44	Aldrich Fan
     2	longxf
     1	Joseph Hellerstein

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 863

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps.
The paper compilation error above seems to relate to the fact that the paper lacks the required YAML content. Please update the paper as per our guidelines and include the required YAML content.

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 👋

@longxf21
Copy link

longxf21 commented Sep 26, 2024 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 have you updated the paper yet?

@longxf21
Copy link

longxf21 commented Oct 14, 2024 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python
Submitting author: @davidtourigny
Handling editor: @marcosvital (Active)
Reviewers: @jdbrunner, @pstjohn, @synchon
Similarity score: 0.7309

Fast and flexible simulation and parameter estimation for synthetic biology using bioscrape
Submitting author: @ayush9pandey
Handling editor: @csoneson (Active)
Reviewers: @Farnazmdi, @Robaina
Similarity score: 0.7212

BASICO: A simplified Python interface to COPASI
Submitting author: @fbergmann
Handling editor: @marcosvital (Active)
Reviewers: @ayush9pandey, @jguhlin, @darogan
Similarity score: 0.7139

ChemPy: A package useful for chemistry written in Python
Submitting author: @bjodah
Handling editor: @kyleniemeyer (Active)
Reviewers: @bryanwweber
Similarity score: 0.7053

Heta compiler: a software tool for the development of large-scale QSP models and compilation into simulation formats
Submitting author: @metelkin
Handling editor: @fboehm (Active)
Reviewers: @martinmodrak, @elimillera
Similarity score: 0.7014

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 thanks for updating the paper. That compiled now and I had a quick look, and have some comments below:

  • Please add the country (in full, please do not use acronyms) to the affiliations.
  • Check expressiona that should probably read expressions

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @ppxasjsm as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@ppxasjsm
Copy link

I don't think I can do this one I am afraid. My next few weeks are very busy with teaching.

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 please see my comments above ☝️

@longxf21
Copy link

longxf21 commented Nov 1, 2024 via email

@longxf21
Copy link

longxf21 commented Nov 1, 2024 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 yes please do commit and update as requested on a rolling bases.

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 apologies for the delays encountered so far. Many editors have been preoccupied handling other submissions. I hope to be able to invite one today so hopefully that will work out and we'll be able to move on from there.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @RMeli as editor

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python
Submitting author: @davidtourigny
Handling editor: @marcosvital (Active)
Reviewers: @jdbrunner, @pstjohn, @synchon
Similarity score: 0.7250

Fast and flexible simulation and parameter estimation for synthetic biology using bioscrape
Submitting author: @ayush9pandey
Handling editor: @csoneson (Active)
Reviewers: @Farnazmdi, @Robaina
Similarity score: 0.7193

BASICO: A simplified Python interface to COPASI
Submitting author: @fbergmann
Handling editor: @marcosvital (Active)
Reviewers: @ayush9pandey, @jguhlin, @darogan
Similarity score: 0.7097

ChemPy: A package useful for chemistry written in Python
Submitting author: @bjodah
Handling editor: @kyleniemeyer (Active)
Reviewers: @bryanwweber
Similarity score: 0.7054

Heta compiler: a software tool for the development of large-scale QSP models and compilation into simulation formats
Submitting author: @metelkin
Handling editor: @fboehm (Active)
Reviewers: @martinmodrak, @elimillera
Similarity score: 0.7008

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@longxf21
Copy link

@Kevin-Mattheus-Moerman Apologies for the delay, I've checked the compiled paper pdf and the problems are fixed! Thanks!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign @RMeli as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @RMeli is now the editor

@Kevin-Mattheus-Moerman
Copy link
Member

@RMeli thanks for still agreeing to be editor. I'll tag @lucydot @rkurchin @HaoZeke @mbarzegary to see if they can help suggest reviewers too in case you are stuck. Let me know if I can help too.

@Kevin-Mattheus-Moerman
Copy link
Member

@longxf21 we've now assigned an editor @RMeli who will be the point of contact from now on. They will be looking for a set of reviewers now. If at this point you'd like to suggest any reviewers, please feel free to mention their GitHub handles here. But please do leave out the @ symbol so they are not tagged. Thanks!

@RMeli
Copy link

RMeli commented Dec 6, 2024

Hi @ayush9pandey 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7268.

Thank you in advance!

@RMeli
Copy link

RMeli commented Dec 6, 2024

Hi @bjodah 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7268.

Thank you in advance!

@ayush9pandey
Copy link

Happy to review this submission for JOSS.

@RMeli
Copy link

RMeli commented Dec 8, 2024

@editorialbot add @ayush9pandey as reviewer

Thank you very much @ayush9pandey!

@editorialbot
Copy link
Collaborator Author

@ayush9pandey added to the reviewers list!

@RMeli
Copy link

RMeli commented Dec 8, 2024

Hi @davidtourigny 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7268.

Thank you in advance!

@davidtourigny
Copy link

I won't be able to, sorry!

@RMeli
Copy link

RMeli commented Dec 9, 2024

No worries @davidtourigny, thank you for letting me know!

@RMeli
Copy link

RMeli commented Dec 28, 2024

Hi @dilawar 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7268.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Dec 28, 2024

Hi @jrybarczyk 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7268.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@dilawar
Copy link

dilawar commented Dec 30, 2024

Hi @dilawar 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7268.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

Hi @RMeli, I'd love to if timelines are not tight.

@RMeli
Copy link

RMeli commented Dec 30, 2024

@editorialbot set @dilawar as reviewer.

Thank you @dilawar! We usually aim for 6 weeks from the start of the review, but it is not too strict.

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@RMeli
Copy link

RMeli commented Dec 30, 2024

@editorialbot add @dilawar as reviewer.

@editorialbot
Copy link
Collaborator Author

@dilawar added to the reviewers list!

@RMeli
Copy link

RMeli commented Dec 30, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7618.

@jrybarczyk
Copy link

Hi @jrybarczyk 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7268.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

Hi @RMeli ! Thank you for the invitation, I accept.

@RMeli
Copy link

RMeli commented Dec 31, 2024

@jrybarczyk, thank you very much for willing to review! Unfortunately, we already found two reviewers for this paper. I'll keep you in mind when a similar paper pops up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dockerfile pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

9 participants