-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pymnet: A Python Library for Multilayer Networks #6930
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
👋 @ClaudMor, @pitmonticone, and @nwlandry - Thanks for agreeing to review this submission. As you can see above, you each should use the command As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if either of you require some more time. We can also use editorialbot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@danielskatz) if you have any questions/concerns. |
Review checklist for @nwlandryConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Additional comments: This is an excellent software product. It's clear that some major thought went into this package and I think that it's a tremendous contribution to the field. For this reason, I added a few issues which are non-essential (I mentioned this in those particular issues) but will improve the package in years to come. Great work. |
Review checklist for @pitmonticoneConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @ClaudMorConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
thanks @pitmonticone and @ClaudMor for getting started quickly. I see some progress on at least some of the issues already too, so thanks to @ercco and @dataspider |
I have a question for @danielskatz. In one of the final sections of the paper, the authors cite several scientific publications (e.g., kivela2014, cozzo2015structure, kivela2017) as examples of projects that have adopted the open-source software package pymnet . However, the first commit in the pymnet GitHub repository is dated October 2020. This suggests that the software was not publicly available as an open-source package, or even as supplementary code, at the time those earlier publications were written. How does JOSS handle citations of projects that purportedly used code before it was publicly available as an open-source package? Specifically:
Your guidance on addressing this issue would be greatly appreciated, as I am not at all sure how to evaluate this. Thank you in advance for your assistance. |
@pitmonticone - I don't see an issue here. The paper is about the software, and projects that have used it are just statement about those projects seeing some value in it. The license and status of the software at that time probably doesn't have anything to do with the value projects saw in using it. You can ask the authors about this, if you want, but I personally don't think the how they accessed it is necessary to add in the paper. JOSS certainly doesn't have any policies on this. |
Ok, thank you very much for the clarification @danielskatz. |
@pitmonticone The first commit is actually from 2013. The original software was mainly available on BitBucket up until some years ago, after which it was moved to GitHub. |
Thank you very much, @arashbm, for the reference. I reviewed the GitHub commit history from browser but wasn't able to locate it. |
@editorialbot generate pdf |
@danielskatz According to this reviewer comment: mnets/pymnet#24, we have updated the paper title to one suggested by the reviewer ( |
👋 @ercco - my suggested changes are in mnets/pymnet#51 Please merge this, or let me know what you disagree with, then we can proceed. |
@danielskatz - I have now merged the suggested changes! |
@editorialbot generate pdf |
@ercco - please check this PDF to make sure everything looks ok, including the changes. If so, then:
I can then move forward with accepting the submission. |
@editorialbot generate pdf |
The figure placement was a bit awkward in the article pdf, leading to large white spaces at the bottom of pages 2 and 3. I moved and scaled figure 1 slightly to make the layout better. |
@danielskatz Here are the archived and tagged versions of pymnet - we bumped the version number to 1.0.0:
|
@editorialbot set 10.5281/zenodo.12806499 as archive |
Done! archive is now 10.5281/zenodo.12806499 |
@editorialbot set v1.0.0 as version |
Done! version is now v1.0.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5668, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @ercco (Tarmo Nurmi) and co-authors on your publication!! And thanks to @ClaudMor, @pitmonticone and @nwlandry for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
On behalf of all of us, a huge thank you to @ClaudMor, @pitmonticone, @nwlandry, and @danielskatz! All of your comments and suggestions really made the library and the paper much better, thank you for your work. This was a very smooth process overall. |
Submitting author: @ercco (Tarmo Nurmi)
Repository: https://github.com/mnets/pymnet
Branch with paper.md (empty if default branch): publication
Version: v1.0.0
Editor: @danielskatz
Reviewers: @ClaudMor, @pitmonticone, @nwlandry
Archive: 10.5281/zenodo.12806499
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ClaudMor & @pitmonticone & @nwlandry, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @pitmonticone
📝 Checklist for @nwlandry
📝 Checklist for @ClaudMor
The text was updated successfully, but these errors were encountered: