-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: planetMagFields: A Python package for analyzing and plotting planetary magnetic field data #6677
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
@athulpg007, @kjg136 — This is the review thread for the paper. All of our correspondence will happen here from now on. Thanks again for agreeing to participate! 👉 Please read the "Reviewer instructions & questions" in the first comment above, and generate your checklists by commenting The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please try to make a start ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. Please get your review started as soon as possible! |
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Review checklist for @kjg136Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @athulpg007Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@AnkitBarik please take a look at the comments below. More details are available in the linked issues.
|
Thanks for addressing the above issues. Please also see: AnkitBarik/planetMagFields#11 |
I have completed my initial review of the submission. This is a useful package for researchers working in the area of planetary magnetic fields by providing a fast method of plotting field data for various planets. The package is well written, along with documentation and examples to help new users get started. My concerns raised earlier have been fixed, thanks. Please see further comments below:
My suggestion is to shorten the paper to ~5 pages or less, including references. It would then be easier for a diverse, non-specialist audienceto quickly get a high-level understanding of the package, and then refer to the documentation for more mathematical details, example Jupyter notebook etc.
Thanks! |
@athulpg007 Thank you very much for the comments. I have made the following changes:
Thank you! |
@editorialbot generate pdf |
I have completed my review of the submission, including the changes made in response to the first reviewer's comments. I agree that the package is useful for visualizing and analyzing planetary magnetic fields. To my knowledge, the authors are correct in their statement that no such package for a high-level language is currently established and therefore, the submission represents a valuable contribution. The documentation and examples are clear, making the package easy to understand and use. I see no major issues and wish to only make two quick comments:
|
Thanks for the updates to the paper. I have completed my review, and recommend to accept this submission. |
@kjg136 @athulpg007 Thank you very much for your reviews. I have fixed the grammatical error. |
@editorialbot generate pdf |
I made one last change to the paper, I updated the citation for |
@editorialbot generate pdf |
|
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
No declaration for attribute displaystyle of element mfrac |
@AnkitBarik — I know that that error message is a little opaque, but my guess is that the issue here is with the use of |
@dfm I have switched it to \frac and verified that it still looks fine on the pdf. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5337, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@athulpg007, @kjg136 — Many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @AnkitBarik — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@dfm @athulpg007 @kjg136 This is wonderful! Thank you very much for help and reviews ! 🎉🎉🎉 |
Congratulations @AnkitBarik! |
JOSS is happy for you to post to arXiv and you can use |
@editorialbot generate preprint |
📄 Preprint file created: Find it here in the Artifacts list 📄 |
Submitting author: @AnkitBarik (Ankit Barik)
Repository: https://github.com/AnkitBarik/planetMagFields
Branch with paper.md (empty if default branch):
Version: 1.4.3
Editor: @dfm
Reviewers: @athulpg007, @kjg136
Archive: 10.5281/zenodo.4690524
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@athulpg007 & @kjg136, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @kjg136
📝 Checklist for @athulpg007
The text was updated successfully, but these errors were encountered: