Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Microbiome.jl and BiobakeryUtils.jl - Julia packages for working with microbial community data #3841

Closed
whedon opened this issue Oct 21, 2021 · 41 comments

Comments

@whedon
Copy link

whedon commented Oct 21, 2021

Submitting author: @kescobo (Bonham, Kevin)
Repository: https://github.com/EcoJulia/Microbiome.jl
Version: v0.8.0
Editor: @will-rowe
Reviewers: @adRn-s, @aguang
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/450fa18f47932c5fd3b837edeac91440"><img src="https://joss.theoj.org/papers/450fa18f47932c5fd3b837edeac91440/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/450fa18f47932c5fd3b837edeac91440/status.svg)](https://joss.theoj.org/papers/450fa18f47932c5fd3b837edeac91440)

Author instructions

Thanks for submitting your paper to JOSS @kescobo. Currently, there isn't an JOSS editor assigned to your paper.

@kescobo if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Oct 21, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 21, 2021

Wordcount for paper.md is 963

@whedon
Copy link
Author

whedon commented Oct 21, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.05 s (741.6 files/s, 148387.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              4              2              2           4024
Julia                           10            282             53           1178
Markdown                        10            295              0            952
TeX                              1             17              0            180
YAML                             7              4             10            154
TOML                             4              4              0             46
-------------------------------------------------------------------------------
SUM:                            36            604             65           6534
-------------------------------------------------------------------------------


Statistical information for the repository '5aa6f9e15e63d2a740f5b4d1' was
gathered on 2021/10/21.
No commited files with the specified extensions were found.

@whedon
Copy link
Author

whedon commented Oct 21, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@kescobo thanks for this submission. I will be helping to look for a handling editor.

@kescobo Note that in the readme for Microbiome.nl you point to: https://github.com/EcoJulia/BiobakeryUtils which gives a 404 error since the .jl part is missing, the correct URL seems to be: https://github.com/EcoJulia/BiobakeryUtils.jl

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon
Copy link
Author

whedon commented Oct 21, 2021

Wordcount for paper.md is 963

@whedon
Copy link
Author

whedon commented Oct 21, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.08 s (457.9 files/s, 91615.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              4              2              2           4024
Julia                           10            282             53           1178
Markdown                        10            295              0            952
TeX                              1             17              0            180
YAML                             7              4             10            154
TOML                             4              4              0             46
-------------------------------------------------------------------------------
SUM:                            36            604             65           6534
-------------------------------------------------------------------------------


Statistical information for the repository 'c7bc34945e30b0a74b634f87' was
gathered on 2021/10/21.
No commited files with the specified extensions were found.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Oct 21, 2021

@openjournals/dev I think the above is for the Microbiome.jl package alone. Is there an easy way for me to also check the BiobakeryUtils.jl package? I tried the below but it seems to ignore the URL:

@whedon check repository https://github.com/EcoJulia/BiobakeryUtils.jl

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon check references

@whedon
Copy link
Author

whedon commented Oct 21, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3390/nu13082833 is OK
- 10.3390/microorganisms9081608 is OK
- 10.1137/141000671 is OK
- 10.21105/joss.03349 is OK
- 10.7554/eLife.65088 is OK
- 10.5281/zenodo.5566503 is OK

MISSING DOIs

- 10.1186/s13059-017-1359-z may be a valid DOI for title: Experimental design and quantitative analysis of microbial community multiomics
- 10.5334/jors.151 may be a valid DOI for title: Differentialequations.jl–a performant and feature-rich ecosystem for solving differential equations in julia

INVALID DOIs

- 10.3389/fmicb.2021.670336 is INVALID

@Kevin-Mattheus-Moerman
Copy link
Member

@kescobo can you check these DOI's? ☝️ Note that if you'd like to update the paper you can call @whedon generate pdf, and you can also call @whedon check references.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @will-rowe as editor

@whedon
Copy link
Author

whedon commented Oct 21, 2021

@will-rowe has been invited to edit this submission.

@kescobo
Copy link

kescobo commented Oct 21, 2021

@Kevin-Mattheus-Moerman Thanks for getting this ball rolling! Just tagging my co-authors, @annelle-abatoni @anikaluo @vanjakle

Re: link in readme: fixed here

Re: DOIs:

  • missing DOIs found by Whedon were correct - added here
  • Invalid doi is bizarre - this is the paper, and the DOIs listed there match what's included here, but the links even from the publisher's website are invalid. I'll reach out to them to see what the issue is.

@kescobo
Copy link

kescobo commented Oct 22, 2021

@whedon check references

@whedon
Copy link
Author

whedon commented Oct 22, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3390/nu13082833 is OK
- 10.3390/microorganisms9081608 is OK
- 10.3389/fmicb.2021.670336 is OK
- 10.1186/s13059-017-1359-z is OK
- 10.1137/141000671 is OK
- 10.5334/jors.151 is OK
- 10.21105/joss.03349 is OK
- 10.7554/eLife.65088 is OK
- 10.5281/zenodo.5566503 is OK

MISSING DOIs

- 10.1186/s13059-017-1359-z may be a valid DOI for title: Experimental design and quantitative analysis of microbial community multiomics

INVALID DOIs

- None

@kescobo
Copy link

kescobo commented Oct 22, 2021

Unclear on the missing one - does this need to be in curly braces?

@Kevin-Mattheus-Moerman
Copy link
Member

@kescobo I think that DOI looks fine. Our system for checking these isn't always correct. I'll inform @openjournals/dev about this one too in case it helps make the system better.

@Kevin-Mattheus-Moerman
Copy link
Member

@will-rowe could you help edit this one?

@will-rowe
Copy link

Hi. Sorry for the delay. Yes, I can take it

@will-rowe
Copy link

Hi @Adrianzo and @aguang - would either of you be able to review this please?

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @will-rowe as editor

@whedon
Copy link
Author

whedon commented Oct 26, 2021

OK, the editor is @will-rowe

@danielskatz
Copy link

👋 @will-rowe - if you want, you can always do this yourself when you agree to edit a paper

@whedon assign @will-rowe as editor

@kescobo
Copy link

kescobo commented Oct 26, 2021

Excellent, thanks @will-rowe!

@aguang
Copy link

aguang commented Oct 27, 2021

Hi @Adrianzo and @aguang - would either of you be able to review this please?

Yes, I can review.

@adRn-s
Copy link

adRn-s commented Oct 28, 2021

Nice paper!

@kescobo I couldn't find the docs

@will-rowe
Copy link

Thanks @aguang ! I'll find one more reviewer and then we will kick off the review process.

@will-rowe
Copy link

Hi @adRn-s - just on the off chance seeing as you've commented here, would you be willing to review this paper for JOSS?

@adRn-s
Copy link

adRn-s commented Oct 28, 2021

Yes. Sorry for the misunderstanding, I'm no longer using the other account (@Adrianzo), but I got here because of the e-mail/ mention.

@kescobo
Copy link

kescobo commented Oct 28, 2021

Nice paper!

Thanks!

I couldn't find the docs

Oops! Looks like that link didn't get fixed - we recently moved from BioJulia to EcoJulia github org and those ones slipped through. Fixed here, but for easy reference:

"Stable" points to the docs for the latest release, and "latest" points to docs for the main branch, even if unreleased. Looking just now, the BiobakeryUtils stable version is actually pointing to very old docs, but "latest" is working correctly. I will investigate.

@kescobo
Copy link

kescobo commented Nov 1, 2021

Alright! Finally got the "stable" docs for BiobakeryUtils to build correctly.

@adRn-s and @aguang thanks for agreeing to review! It's up to you of course, but I suggest starting here in the docs

@adRn-s
Copy link

adRn-s commented Nov 1, 2021

Great!

PS. I had some issue, but apparently it was my connectivity

@will-rowe
Copy link

Hi all. I'm having some Github difficulties with this thread for some reason. I will assign our reviewers and move this to a review issue. Thank you for agreeing to review and to @kescobo for getting the docs ready

@will-rowe
Copy link

@whedon assign @adRn-s as reviewer

@whedon whedon assigned adRn-s and will-rowe and unassigned will-rowe Nov 2, 2021
@whedon
Copy link
Author

whedon commented Nov 2, 2021

OK, @adRn-s is now a reviewer

@will-rowe
Copy link

@whedon add @aguang as reviewer

@whedon whedon assigned adRn-s, aguang and will-rowe and unassigned will-rowe and adRn-s Nov 2, 2021
@whedon
Copy link
Author

whedon commented Nov 2, 2021

OK, @aguang is now a reviewer

@will-rowe
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 2, 2021

OK, I've started the review over in #3876.

@whedon whedon closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants