8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache

[sendaoYan]

Hi all,
There are 4 tests fails run with JVM option '-XX:+SegmentedCodeCache'. JVM option '-XX:ReservedCodeCacheSize=4m' inside test conflict with JVM option '-XX:+SegmentedCodeCache' which pass from outside test. This PR add '-XX:-SegmentedCodeCache' explicitly inside test to make test run success whenever received '-XX:+SegmentedCodeCache' outside or not. Change has been verified locally, test-fix only, make test more robustness, no risk.

'SegmentedCodeCache' is enable by default

> java -XX:+PrintFlagsFinal 2>&1 | grep -P "(SegmentedCodeCache)|(ReservedCodeCacheSize)"
    uintx ReservedCodeCacheSize                    = 251658240                              {pd product} {ergonomic}
     bool SegmentedCodeCache                       = true                                      {product} {ergonomic}

Pass '-XX:ReservedCodeCacheSize=4m' to JVM will automatic disable SegmentedCodeCache

> java -XX:ReservedCodeCacheSize=4m -XX:+PrintFlagsFinal 2>&1 | grep -P "(SegmentedCodeCache)|(ReservedCodeCacheSize)"
    uintx ReservedCodeCacheSize                    = 4194304                                {pd product} {command line}
     bool SegmentedCodeCache                       = false                                     {product} {default}

'-XX:+SegmentedCodeCache' conflict with '-XX:ReservedCodeCacheSize=4m'

> java -XX:ReservedCodeCacheSize=4m -XX:+SegmentedCodeCache -version
Error occurred during initialization of VM
Invalid code heap sizes: NonNMethodCodeHeapSize (8006K) + ProfiledCodeHeapSize (4K) + NonProfiledCodeHeapSize (4K) = 8014K is greater than ReservedCodeCacheSize (4096K).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22926/head:pull/22926
$ git checkout pull/22926

Update a local copy of the PR:
$ git checkout pull/22926
$ git pull https://git.openjdk.org/jdk.git pull/22926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22926

View PR using the GUI difftool:
$ git pr show -t 22926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22926.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 8d388cc: 8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries"
• d723597: 8345432: (ch, fs) Replace anonymous Thread with InnocuousThread
• 9c393a2: 8346953: Remove unnecessary @SuppressWarnings annotations (client, Make "can write" check work on Windows #2)
• 9a60f44: 8345668: ZoneOffset.ofTotalSeconds performance regression
• 12700cb: 8346264: "Total compile time" counter should include time spent in failing/bailout compiles
• dd81f8d: 8344079: Minor fixes and cleanups to compiler lint-related code
• ccf3d57: 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API
• 594e519: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks
• c027f2e: 8346983: Remove ASM-based transforms from Class-File API tests
• e0695e0: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
• ... and 1 more: https://git.openjdk.org/jdk/compare/f1d85ab3e61f923b4e120cf30e16109e04505b53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0fc31313)

[dafedafe]

Also, as the failing tests are 4, it might be a good idea to update the title.

[sendaoYan]

Also, as the failing tests are 4, it might be a good idea to update the title.

Okay, the title has been updated.

[sendaoYan]

/issue JDK-8346965

[openjdk]

@sendaoYan This issue is referenced in the PR title - it will now be updated.

[vnkozlov]

Looks good.

[sendaoYan]

GHA report 1 failure:

1. 'macos-x64 / test - Test (tier1)' job fails 'GitHub Actions 11 lost communication with the server.', it seems like environmental issue, it's unrelated to this PR.

[sendaoYan]

Thanks all for the advice and review.

/integrate

[openjdk]

Going to push as commit cf3e48e.
Since your change was applied there have been 22 commits pushed to the master branch:

• e5f0c19: 8345041: IGV: Free Placement Mode in IGV Layout
• 8b22517: 8211851: (ch) java/nio/channels/AsynchronousSocketChannel/StressLoopback.java times out (aix)
• 5e6cda4: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
• 3f7052e: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689
• f119663: 8346573: Can't use custom default file system provider with custom system class loader
• 379ac34: 8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
• 0285020: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64
• 0a81676: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer
• 08debd3: 8346993: C2 SuperWord: refactor to make more vector nodes available in VectorNode::make
• de02503: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V
• ... and 12 more: https://git.openjdk.org/jdk/compare/f1d85ab3e61f923b4e120cf30e16109e04505b53...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit cf3e48e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.