8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer #22903

MBaesken · 2025-01-02T12:59:42Z

When running jtreg tests on macOS aarch64 with ubsanized binaries, the following error is reported :

jdk/src/hotspot/share/logging/logSelection.cpp:154:24: runtime error: applying non-zero offset 1 to null pointer
UndefinedBehaviorSanitizer:DEADLYSIGNAL
UndefinedBehaviorSanitizer: nested bug in the same thread, aborting.

(XCode 13.1 was used)

This can be seen e.g. in these jdk jtreg tests :
jdk/internal/misc/CDS/ArchivedEnumTest.java
jdk/jfr/event/gc/collection/TestGCGarbageCollectionEvent.java
jdk/jfr/startupargs/TestDumpOnExit.java

There is another issue observed here (also when running on macOS aarch64) , seems this happens in the for loop when incrementing comma_pos
" for (char *comma_pos = copy, *cur = copy; success && comma_pos != nullptr; cur = comma_pos + 1) { ..."

src/hotspot/share/logging/logSelectionList.cpp:72:94: runtime error: applying non-zero offset 1 to null pointer
UndefinedBehaviorSanitizer:DEADLYSIGNAL
UndefinedBehaviorSanitizer: nested bug in the same thread, aborting.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer (Bug - P4)

Reviewers

Christoph Langer (@RealCLanger - Reviewer)
Martin Doerr (@TheRealMDoerr - Reviewer)
David Holmes (@dholmes-ora - Reviewer)
SendaoYan (@sendaoYan - Committer)
Amit Kumar (@offamitkumar - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22903/head:pull/22903
$ git checkout pull/22903

Update a local copy of the PR:
$ git checkout pull/22903
$ git pull https://git.openjdk.org/jdk.git pull/22903/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22903

View PR using the GUI difftool:
$ git pr show -t 22903

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22903.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-01-02T13:00:45Z

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-01-02T13:01:07Z

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346881: [ubsan] logSelection.cpp:154:24  / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer

Reviewed-by: clanger, mdoerr, dholmes, syan, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

f1d85ab: 8346773: Fix unmatched brackets in some misc files
9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved
84e6432: 8346288: WB_IsIntrinsicAvailable fails if called with wrong compilation level

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-01-02T13:01:39Z

@MBaesken The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-01-02T13:05:06Z

Webrevs

RealCLanger · 2025-01-02T13:15:17Z

src/hotspot/share/logging/logSelectionList.cpp

+
+    if (comma_pos == nullptr) {
+      break;
+    }


I think this check is not necessary here since it is checked in the for loop condition already - or am I overlooking something?

Unfortunately we still run into the issue , even with the existing loop condition.
check the flowchart of the for loop
https://www.programiz.com/cpp-programming/for-loop
the update condition is done after the body ; then we run into the issue.

Ah, right, I see. But in that case, we can/should remove the check for comma_pos != nullptr from the condition because we're explicitly doing it in the loop body then.

Agree, the check can be simplified .

MBaesken · 2025-01-02T15:45:35Z

Seems we have a similar one here, show by test runtime/MemberName/MemberNameLeak (macOS aarch64)

src/hotspot/share/logging/logDecorators.cpp:103:23: runtime error: applying non-zero offset 1 to null pointer

Should I address it here too ?

RealCLanger · 2025-01-03T08:08:14Z

Seems we have a similar one here, show by test runtime/MemberName/MemberNameLeak (macOS aarch64)

src/hotspot/share/logging/logDecorators.cpp:103:23: runtime error: applying non-zero offset 1 to null pointer

Should I address it here too ?

yes, makes sense.

MBaesken · 2025-01-03T08:54:53Z

I adjusted logDecorators.cpp too .

RealCLanger

I think for the sake of consistency, the loop in logSelectionList.cpp could be transformed into a do {} while(), like in the other two locations, but in any case, the change looks good to me as it is now.

TheRealMDoerr

LGTM.

MBaesken · 2025-01-03T11:47:53Z

Thanks for the reviews !

dholmes-ora

LGTM2

Thanks

sendaoYan

LGTM

offamitkumar · 2025-01-06T07:08:12Z

I think for the sake of consistency, the loop in logSelectionList.cpp could be transformed into a do {} while(), like in the other two locations, but in any case, the change looks good to me as it is now.

I think for loop is better choice for this kind of occasion. Because in logDecorators.cpp :

  char* token = args_copy;
  char* comma_pos;

these two variables are doing no good by being in function scope. If it would have been a for loop then then would exist in the loop's scope only. As that's the case for comma_pos and cur here:

for (char *comma_pos = copy, *cur = copy; success; cur = comma_pos + 1) {

It might not be a big deal but still I find later one appropriate :-)

MBaesken · 2025-01-07T08:09:11Z

Thanks for the reviews !

/integrate

openjdk · 2025-01-07T08:10:31Z

Going to push as commit 0a81676.
Since your change was applied there have been 20 commits pushed to the master branch:

08debd3: 8346993: C2 SuperWord: refactor to make more vector nodes available in VectorNode::make
de02503: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V
27646e5: 8344148: Add an explicit compiler phase for warning generation
8d388cc: 8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries"
d723597: 8345432: (ch, fs) Replace anonymous Thread with InnocuousThread
9c393a2: 8346953: Remove unnecessary @SuppressWarnings annotations (client, Make "can write" check work on Windows #2)
9a60f44: 8345668: ZoneOffset.ofTotalSeconds performance regression
12700cb: 8346264: "Total compile time" counter should include time spent in failing/bailout compiles
dd81f8d: 8344079: Minor fixes and cleanups to compiler lint-related code
ccf3d57: 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API
... and 10 more: https://git.openjdk.org/jdk/compare/a77ed30fcc3360cd16a11b1899f52f7e871df1df...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-07T08:10:40Z

@MBaesken Pushed as commit 0a81676.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8346881

d25d806

openjdk bot added the rfr Pull request is ready for review label Jan 2, 2025

openjdk bot added the hotspot-runtime [email protected] label Jan 2, 2025

RealCLanger reviewed Jan 2, 2025

View reviewed changes

for loop check has been moved

9fd0a5a

address iteration in logDecorators.cpp

e67c271

RealCLanger approved these changes Jan 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2025

TheRealMDoerr approved these changes Jan 3, 2025

View reviewed changes

dholmes-ora approved these changes Jan 6, 2025

View reviewed changes

sendaoYan approved these changes Jan 6, 2025

View reviewed changes

offamitkumar approved these changes Jan 6, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jan 7, 2025

openjdk bot closed this Jan 7, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer #22903

8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer #22903

MBaesken commented Jan 2, 2025 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 2, 2025

openjdk bot commented Jan 2, 2025 •

edited

Loading

openjdk bot commented Jan 2, 2025

mlbridge bot commented Jan 2, 2025 •

edited

Loading

RealCLanger Jan 2, 2025

MBaesken Jan 2, 2025

RealCLanger Jan 2, 2025

MBaesken Jan 2, 2025

MBaesken commented Jan 2, 2025 •

edited

Loading

RealCLanger commented Jan 3, 2025

MBaesken commented Jan 3, 2025

RealCLanger left a comment

TheRealMDoerr left a comment

MBaesken commented Jan 3, 2025

dholmes-ora left a comment

sendaoYan left a comment

offamitkumar commented Jan 6, 2025

MBaesken commented Jan 7, 2025

openjdk bot commented Jan 7, 2025

openjdk bot commented Jan 7, 2025

8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer #22903

8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer #22903

Conversation

MBaesken commented Jan 2, 2025 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 2, 2025

openjdk bot commented Jan 2, 2025 • edited Loading

openjdk bot commented Jan 2, 2025

mlbridge bot commented Jan 2, 2025 • edited Loading

Webrevs

RealCLanger Jan 2, 2025

Choose a reason for hiding this comment

MBaesken Jan 2, 2025

Choose a reason for hiding this comment

RealCLanger Jan 2, 2025

Choose a reason for hiding this comment

MBaesken Jan 2, 2025

Choose a reason for hiding this comment

MBaesken commented Jan 2, 2025 • edited Loading

RealCLanger commented Jan 3, 2025

MBaesken commented Jan 3, 2025

RealCLanger left a comment

Choose a reason for hiding this comment

TheRealMDoerr left a comment

Choose a reason for hiding this comment

MBaesken commented Jan 3, 2025

dholmes-ora left a comment

Choose a reason for hiding this comment

sendaoYan left a comment

Choose a reason for hiding this comment

offamitkumar commented Jan 6, 2025

MBaesken commented Jan 7, 2025

openjdk bot commented Jan 7, 2025

openjdk bot commented Jan 7, 2025

MBaesken commented Jan 2, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jan 2, 2025 •

edited

Loading

mlbridge bot commented Jan 2, 2025 •

edited

Loading

MBaesken commented Jan 2, 2025 •

edited

Loading