8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries"

[calvinccheung]

Avoid calling InstanceKlass::compute_has_loops_flag_for_methods() when a class has failed verification during CDS dump. It is to avoid assert in subsequent byte code verification such as in Bytecode_lookupswitch::verify().

Testing: tiers 1 - 4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries" (Bug - P2)(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 25, a new backport will be created when this pr is integrated.)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22871/head:pull/22871
$ git checkout pull/22871

Update a local copy of the PR:
$ git checkout pull/22871
$ git pull https://git.openjdk.org/jdk.git pull/22871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22871

View PR using the GUI difftool:
$ git pr show -t 22871

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22871.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries"

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
• e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
• ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
• 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved
• 84e6432: 8346288: WB_IsIntrinsicAvailable fails if called with wrong compilation level
• a77ed30: 8336412: sun.net.www.MimeTable has a few unused methods
• e769b53: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17
• a87bc7e: 8345374: Ubsan: runtime error: division by zero
• d3abf01: 8346101: [JVMCI] Export jdk.internal.misc to jdk.graal.compiler
• 24c5ff7: 8346871: Improve robustness of java/util/zip/EntryCount64k.java test
• ... and 18 more: https://git.openjdk.org/jdk/compare/b8e40b9c2dfecdad9096015c1aa208ea077db7f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ceef376d)

[iklam]

LGTM

[dholmes-ora]

This seems quite reasonable.

Thanks

[calvinccheung]

Thanks @iklam, @dholmes-ora for the review.

/integrate

[openjdk]

Going to push as commit 8d388cc.
Since your change was applied there have been 39 commits pushed to the master branch:

• d723597: 8345432: (ch, fs) Replace anonymous Thread with InnocuousThread
• 9c393a2: 8346953: Remove unnecessary @SuppressWarnings annotations (client, Make "can write" check work on Windows #2)
• 9a60f44: 8345668: ZoneOffset.ofTotalSeconds performance regression
• 12700cb: 8346264: "Total compile time" counter should include time spent in failing/bailout compiles
• dd81f8d: 8344079: Minor fixes and cleanups to compiler lint-related code
• ccf3d57: 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API
• 594e519: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks
• c027f2e: 8346983: Remove ASM-based transforms from Class-File API tests
• e0695e0: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
• dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
• ... and 29 more: https://git.openjdk.org/jdk/compare/b8e40b9c2dfecdad9096015c1aa208ea077db7f5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 8d388cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.