8343925: [BACKOUT] JDK-8342650 Move getChars to DecimalDigits

[wenshao]

8343925 Feedback PR #21593 test/jdk/java/util/BitSet/HugeToString.java crash,

I can't reproduce the problem on a MacBook M1 Max, but I agree that more testing is needed, so let's roll it back first.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8343925: [BACKOUT] JDK-8342650 Move getChars to DecimalDigits (Bug - P2)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)
• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22012/head:pull/22012
$ git checkout pull/22012

Update a local copy of the PR:
$ git checkout pull/22012
$ git pull https://git.openjdk.org/jdk.git pull/22012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22012

View PR using the GUI difftool:
$ git pr show -t 22012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22012.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wenshao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343925: [BACKOUT] JDK-8342650 Move getChars to DecimalDigits

Reviewed-by: jpai, alanb, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 0759224: 8342105: JVM Crash when Jacoco and JFR are active
• babb52a: 8343931: Removed unused code in CompressedKlassPointers::initialize_for_given_encoding
• 2ec3580: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs
• f3ba767: 8343535: IGV: Colorize nodes on demand
• 5016132: 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException
• 36e1295: 8343929: Remove PreservedMarksSet::createTask() after JDK-8305895
• b1a9491: 8343321: Bad verify in LockStack::oops_do()
• cbe8448: 8268895: Do not filter out man pages from build
• ec13364: 8343067: C2: revisit constant-offset AddP chains after successful input idealizations
• 5ca6698: 8341176: Permit access to diagnostics for transient snippets
• ... and 5 more: https://git.openjdk.org/jdk/compare/e1d684c6451ae7875b61a92603c19336ccd734d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wenshao The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-compiler
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e715f8f2)

[wenshao]

It has been verified that it is caused by unsafe offset overflow. The problem has been reproduced and fixed. I submitted PR #22014. Would you consider fixing it this way?

[AlanBateman]

Changes in this area need to be very carefully reviewed and tested. I think continue with the current plan to blackout the original change and seek wider review and testing for the REDO.

Chen is testing the blackout now.

[jaikiran]

I have verified that this backout matches a git revert of the commit that introduced the change in https://bugs.openjdk.org/browse/JDK-8342650. So on that front, this backout looks OK to me.
Alan has noted that Chen is running some tests with this backout. So please wait for that review, before integrating.

/reviewers 2

[openjdk]

@jaikiran
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[AlanBateman]

Thanks for the BACKOUT, looks right.

[liach]

CI results look good.

[wenshao]

/integrate

[openjdk]

Going to push as commit b0a371b.
Since your change was applied there have been 15 commits pushed to the master branch:

• 0759224: 8342105: JVM Crash when Jacoco and JFR are active
• babb52a: 8343931: Removed unused code in CompressedKlassPointers::initialize_for_given_encoding
• 2ec3580: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs
• f3ba767: 8343535: IGV: Colorize nodes on demand
• 5016132: 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException
• 36e1295: 8343929: Remove PreservedMarksSet::createTask() after JDK-8305895
• b1a9491: 8343321: Bad verify in LockStack::oops_do()
• cbe8448: 8268895: Do not filter out man pages from build
• ec13364: 8343067: C2: revisit constant-offset AddP chains after successful input idealizations
• 5ca6698: 8341176: Permit access to diagnostics for transient snippets
• ... and 5 more: https://git.openjdk.org/jdk/compare/e1d684c6451ae7875b61a92603c19336ccd734d6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wenshao Pushed as commit b0a371b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.