8313612: Use JUnit in lib-test/jdk tests

[xqoasis]

Modified all tests under lib-test/jdk to use JUnit

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313612: Use JUnit in lib-test/jdk tests (Sub-task - P4)

Reviewers

• Christian Stein (@sormuras - Committer)
• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15131/head:pull/15131
$ git checkout pull/15131

Update a local copy of the PR:
$ git checkout pull/15131
$ git pull https://git.openjdk.org/jdk.git pull/15131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15131

View PR using the GUI difftool:
$ git pr show -t 15131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15131.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xqoasis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xqoasis The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (7043c900)
• 02: Full - Incremental (e520735d)
• 01: Full - Incremental (0e15e752)
• 00: Full (1ab34e8d)

[sormuras]

Please only keep first and last/latest year of changes.

[liach]

Should all static @Test methods be converted to instance methods, as recommended by JUnit? See https://junit.org/junit5/docs/snapshot/user-guide/#writing-tests-definitions

Test Method
any instance method that is directly annotated or meta-annotated with @Test, ...

[sormuras]

Looks good to me.

Tested with --test test/lib-test/jdk/test/lib.

[openjdk]

@xqoasis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313612: Use JUnit in lib-test/jdk tests

Reviewed-by: cstein, asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 589 new commits pushed to the master branch:

• 455cfae: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• 9e00949: 8316427: Duplicated code for {obj,type}ArrayKlass::array_klass
• c43ebd3: 8315981: Opensource five more random Swing tests
• e30e356: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
• 242eeae: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
• b275bdd: 8308995: Update Network IO JFR events to be static mirror events
• e1870d3: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
• ec74194: 8316546: Backout JDK-8315932: runtime/InvocationTests spend a lot of time on dependency verification
• 2568188: 8316547: Use JUnit.dir jtreg property with jpackage JUnit tests
• 833a828: 8315876: Open source several Swing CSS related tests
• ... and 579 more: https://git.openjdk.org/jdk/compare/6d180d5fbfb7ba2a6cebebe637e791dd540a80d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sormuras, @asotona) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[xqoasis]

/integrate

[openjdk]

@xqoasis
Your change (at version 7043c90) is now ready to be sponsored by a Committer.

[sormuras]

/sponsor

[openjdk]

Going to push as commit a35e96a.
Since your change was applied there have been 600 commits pushed to the master branch:

• bee7524: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX
• ceff47b: 8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
• df4a25b: 8308762: Metaspace leak with Instrumentation.retransform
• 8412479: 8316229: Enhance class initialization logging
• c04c9ea: 8316627: JViewport Test headless failure
• 5cacf21: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
• 3461c7b: 8316532: Native library copying in BuildMicrobenchmark.gmk cause dups on macOS
• 3301fb1: 8315869: UseHeavyMonitors not used
• 54028e7: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829
• 7c991cc: 8296246: Update Unicode Data Files to Version 15.1.0
• ... and 590 more: https://git.openjdk.org/jdk/compare/6d180d5fbfb7ba2a6cebebe637e791dd540a80d7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sormuras @xqoasis Pushed as commit a35e96a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.