8301767: Convert virtual thread tests to JUnit

[AlanBateman]

The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests. We'd like to convert these JUnit in the main line in advance of other updates to these tests in 21. The changes are mostly mechanical and trivial:

• BeforeClass/AfterClass changed to static BeforeAll/AfterAll methods
• Tests using data providers are changed to parameterized tests
• The order of the parameters to assertEquals are swapped so that the expected result is the first parameter
• Usages of expectThrows are changed to assertThrows
• Tests that threw SkipException are changed to the Assumptions API

There are a small number of drive-by changes to the tests, nothing significant, e.g.

• GetStackTrace and ParkWithFixedThreadPool changed from "@run testng" to "@run main" as they aren't TestNG tests.
• A few of the tests in StructuredTaskScopeTest for joinXXX are changed to use a CountDownLatch rather than sleeping, as the original tests weren't very robust.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301767: Convert virtual thread tests to JUnit

Reviewers

• Christian Stein (@sormuras - Committer) ⚠️ Review applies to d89c97c5
• Lance Andersen (@LanceAndersen - Reviewer) ⚠️ Review applies to d89c97c5
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12426/head:pull/12426
$ git checkout pull/12426

Update a local copy of the PR:
$ git checkout pull/12426
$ git pull https://git.openjdk.org/jdk pull/12426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12426

View PR using the GUI difftool:
$ git pr show -t 12426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12426.diff

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman The following labels will be automatically applied to this pull request:

• core-libs
• jmx
• net
• nio
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[AlanBateman]

/label remove jmx
/label remove nio
/label remove net

[openjdk]

@AlanBateman
The jmx label was successfully removed.

[openjdk]

@AlanBateman
The nio label was successfully removed.

[openjdk]

@AlanBateman
The net label was successfully removed.

[mlbridge]

Webrevs

• 03: Full - Incremental (86af1887)
• 02: Full - Incremental (75176342)
• 01: Full (7dc07c4b)
• 00: Full (d89c97c5)

[LanceAndersen]

Changes look good Alan

[openjdk]

@AlanBateman this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8301767
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301767: Convert virtual thread tests to JUnit

Reviewed-by: cstein, lancea, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• c92a7de: 8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java
• 0f08785: 8301756: Missed constructor from 8301659
• 4de2d3c: 8301862: G1: Remove G1PageBasedVirtualSpace::_executable
• e628fd5: 8301214: Adjust handshakeTimeout value in test HandshakeTimeout.java after 8189338
• ac7119f: 8280126: C2: detect and remove dead irreducible loops

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Thank you Alan for the changes. The latest version of this PR (commit 86af188), looks fine to me.

[AlanBateman]

/integrate

[openjdk]

Going to push as commit ecf21a9.
Since your change was applied there have been 7 commits pushed to the master branch:

• 9af2ea2: 8301828: Avoid unnecessary array fill after creation in javax.swing.text
• 3db352d: 8302047: G1: Remove unused G1RegionToSpaceMapper::_region_granularity
• c92a7de: 8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java
• 0f08785: 8301756: Missed constructor from 8301659
• 4de2d3c: 8301862: G1: Remove G1PageBasedVirtualSpace::_executable
• e628fd5: 8301214: Adjust handshakeTimeout value in test HandshakeTimeout.java after 8189338
• ac7119f: 8280126: C2: detect and remove dead irreducible loops

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit ecf21a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.