Skip to content
This repository has been archived by the owner on May 23, 2019. It is now read-only.

Command History in Chat view #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kubawolanin
Copy link

Closes #33

Signed-off-by: Kuba Wolanin [email protected]

@kubawolanin
Copy link
Author

Travis rejected my PR but it's not my fault 😄

[INFO] --- sat-plugin:0.5.0:report (default) @ org.openhab.ui.habot ---
[INFO] Individual report appended to summary report.
[ERROR] Code Analysis Tool has found: 
 1 error(s)! 
 71 warning(s) 
 15 info(s)
[WARNING] .ui.habot/README.md:[11]
The line after a Markdown list must be empty.
[ERROR] .ui.habot/META-INF/MANIFEST.MF:[0]
The manifest version did not match the requirements ^2.4.0

@ghys
Copy link
Member

ghys commented Dec 27, 2018

Cool feature @kubawolanin (and nice to see you back! 🎉)
It's something I have been considering as well but never took the time ;)

One little problem I see is that the array of previous commands will never stop growing - maybe consider using SessionStorage instead? (or keep e.g. the last 50 commands)

Travis rejected my PR but it's not my fault

Yes it's been fixed as part of #32 - should be good now if you rebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants