Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bluetooth package installation #902

Merged
merged 1 commit into from
May 20, 2020

Conversation

holgerfriedrich
Copy link
Member

Signed-off-by: Holger Friedrich [email protected]

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich
Copy link
Member Author

As @mstormi pointed out, #898 fails installing the packages due to the latest shellcheck change. The solution with smallest impact was to remove the quotes again and add an exception.
Other possible way would be to use an array.

Merging (small patch exception)

@holgerfriedrich holgerfriedrich merged commit d6267b5 into openhab:master May 20, 2020
@holgerfriedrich holgerfriedrich deleted the pr-bluez2 branch May 20, 2020 22:38
@mstormi
Copy link
Contributor

mstormi commented May 21, 2020

See https://travis-ci.com/github/openhab/openhabian/builds/167592500
Build fail for x86 and 64-bit OS ARM.
See their logs: seems there's more BT packages that do not exist ?

And replace 'exit' with a 'return', please so install can continue for normal users.

@holgerfriedrich
Copy link
Member Author

@mstormi I do not understand what is going on here, I have those packages installed on my system! I had a closer look, the missing ones seem to be from archive.raspberrypi.org/debian and not from raspbian.raspberrypi.org/raspbian. Let's wait another few days and see the logs.
Thanks for the hotfix, this is good anyway.

@mstormi
Copy link
Contributor

mstormi commented May 21, 2020

Note test builds only fail (due to packages missing) for specific architectures, it's never all of them.

@mstormi mstormi mentioned this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants