Adapt DateTimeType internal switch from ZonedDateTime to Instant in openHAB 4.3 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
force-pushed
the
datetimetype-zdt2
branch
5 times, most recently
from
00dfdf7 to
d051346
Compare
ccutrer
reviewed
Dec 16, 2024
| @@ -48,7 +48,17 @@ def parse(time_string) | |||
| # fields during conversion. Not used in this class. | |||
| # @return [ZonedTimeTime] | |||
| def to_zoned_date_time(context = nil) # rubocop:disable Lint/UnusedMethodArgument | |||
| zoned_date_time | |||
| # @deprecated OH 4.2 Just call zoned_date_time(ZoneId.system_default) in OH 4.3 | |||
| unless instance_variable_defined?(:@zoned_date_time_method) | |||
There was a problem hiding this comment.
This is really inefficient to have to create a method object for every instance of DateTimeType. Instead, do a conditional outside the method, and then define the method (literally) as appropriate
jimtng
force-pushed
the
datetimetype-zdt2
branch
5 times, most recently
from
862aee6 to
b8e0eb3
Compare
jimtng
changed the title
jimtng
changed the title
|
This PR has merits beyond just avoiding the deprecation of |
jimtng
force-pushed
the
datetimetype-zdt2
branch
2 times, most recently
from
e780346 to
3221324
Compare
Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
datetimetype-zdt2
branch
from
3221324 to
a15551b
Compare
ccutrer
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.