-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Appendix]Maybe add a new Remark/Atom Tutorial to Contribution Section #556
Comments
Sounds good! |
Is there a place already where the linter and its installation and operation are discussed? I found it once, but now I cannot locate it. |
At that time I've documented the linter right in the configuration file. That is of course not a good position and whoever does work on this issue may move these details 😃 https://github.com/openhab/openhab-docs/blob/gh-pages/package.json |
Btw. I was also looking into integrating the whole linting process into the continuous integration process. I did not make any progress there but that would also be an interesting step. Before that we should however try to resolve most issues. There are thousands of errors thanks to the various binding READMEs. I did not start working on these yet but that would definitely be something. Last note regarding the remark config: I am currently not happy with the linting rules for lists (e.g. the forced loose list style is not always a good choice). I might change this setting soon, feel free to propose improvements. |
That's why i wanted to get atom running here locally. Maybe we could add those informations splitted to the "correct" files and add some summary article with readme and styleguide as a link. First some general information about the process/workflow and then some more detailed information in the detailed files separated by topic. |
I have installed and configured atom and all necessary packages and node modules, but the linting doesn't seem to recognize the package.json settings. Is there anything special to do additionally? |
no just the steps documented inside the package.json file. What happens when you open a console for the openhab-docs directory, then type:
|
FWIW, installed Atom and lint-md on my Mac with no problem. I tried to install it on a Ubuntu 16.04 Desktop and am getting errors and the linter is not active. When I get a moment I will post the errors here. |
Interesting - reran on Ubuntu 16.04, running npm run-script lint-md on a fully updated system produces the following: Attached is the error log... |
I would be happy to take a crack at writing something about the linter, starting by just pulling the text from the package.json file. But where should it go? I think it should go into a Contributing article, but there are two of them - one in the main documentation, and one in the developers guide. Thoughts? |
I would go for a new article in the main documentation. About the atom issues: |
Whoever moves the linter instructions somewhere more meaningful, please add the following option to run the linter over a certain directory:
|
I have started an outline for this article. That’s why you’re getting all the questions from me on it. Will put up a PR once I have the basics down. |
Regarding the where: I'd move as much content as possible into README.md. |
So you want linter info in the README? |
Sorry i didn't find a better headline.
Basic Idea is inspired from: #423
Related: #418, #196, #50
Also: #530 as a parallel and a bit different approach.
I am not working on Atom yet but want to change to this environment.
I do many things alright already, nevertheless some validation and error notifications would be nice.
Also it would be nice to have some kind of page with good informations for for new contributors to give them a starting point.
So maybe it would make sense to add some kind of FAQ or Overview,
of how the Page is build,
of what is markdown and kramdown,
of what is remark and what is linting
and finally what is a possible Environment for contributing here with some direct feedback from the editor.
I know we have the repo Readme file already and there is some topic overlap to the points above.
But it is very technical and it maybe would be a bit bloated if we fill in all those mentioned things.
This is of course just an early idea and feedback, improvements or additions are welcome as always.
The text was updated successfully, but these errors were encountered: