Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] "Edit this page on GitHub" link #530

Closed
kubawolanin opened this issue Oct 15, 2017 · 7 comments
Closed

[Proposal] "Edit this page on GitHub" link #530

kubawolanin opened this issue Oct 15, 2017 · 7 comments

Comments

@kubawolanin
Copy link
Contributor

The goal of this proposal is to encourage more people to contribute to the documentation pages.

So let's say that user visits this page.
Adding the following example code at the beginning of .content class:

<a href="{{TODO}}" style="float: right">Edit this page on GitHub</a>

Would result in effect like this:
przechwytywanie

The URL would then redirect (or open a new tab if target="_blank" was used) to a GitHub article. In the example above it would be this page.

Resources:

@ThomDietrich
Copy link
Member

ThomDietrich commented Oct 15, 2017

Hey Kuba!
That's a good idea! I was also thinking about adding such a link. I wanted to go with a Materialize floating action button for it.

The big problem is that the majority of content in docs is not actually hosted in the docs repo and the URL to the original file would need to be known. To that end I started to add the source front matter to files, see here for an example. However (it would be possible) not all files can be provided with that field easily. That's why I've just recently discussed the idea of additional metadata for addons with @kaikreuzer. We wanted to discuss this in more detail at the Smart Home Day. You should join! 😉 (Let me know if you are interested in more details)

Best! Thomas

@kubawolanin
Copy link
Contributor Author

Let me know if you are interested in more details

Sure I am :)
And I really like the idea of incorporating floating button there.

Cheers,
Kuba

@bgilmer77
Copy link
Contributor

Would the source front matter be applicable to other areas of the docs? As you know, we have other places where an article may appear in openhab-docs, but it is actually an ESH article. (Or is this a different concept?)

@ThomDietrich
Copy link
Member

The exact same topic yes. I've started another discussion that hopefully will soon help with the this feature

@Confectrician
Copy link
Contributor

I've started another discussion that hopefully will soon help with the this feature

Could you link it here, if its a public visible discussion?
Would be nice to have an impression of the whole topic.

@ThomDietrich
Copy link
Member

ThomDietrich commented Nov 9, 2017

Sure, here you go: eclipse-archived/smarthome#4503 (also @kubawolanin)

@kaikreuzer
Copy link
Member

@ghys has added such links on the new website, so I guess this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants