Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a note about removal of DarkSky binding due to EOL of their API #1404

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Added a note about removal of DarkSky binding due to EOL of their API #1404

merged 3 commits into from
Dec 30, 2022

Conversation

cweitkamp
Copy link
Contributor

  • Added a note about removal of DarkSky binding due to EOL of their API

Signed-off-by: Christoph Weitkamp [email protected]

@cweitkamp cweitkamp requested a review from a team as a code owner June 29, 2022 10:38
@wborn wborn added the awaiting other PR Depends on another PR label Jul 16, 2022
@wborn
Copy link
Member

wborn commented Jul 16, 2022

Depends on openhab/openhab-addons#13037

@wborn wborn added this to the 4.0 milestone Nov 5, 2022
@wborn wborn removed the awaiting other PR Depends on another PR label Dec 21, 2022
wborn
wborn requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the other PR got merged, can you rebase this one and add it to a [4.0.0] section?

@cweitkamp
Incorporate changes from review
4b13b12 
Signed-off-by: Christoph Weitkamp <[email protected]>
@wborn wborn removed this from the 4.0 milestone Dec 29, 2022
@cweitkamp
Copy link
Contributor Author

There's still a merge conflict.

Sry, didn't notice. Looks like you already rebased and applied your comment. Thanks.

wborn
wborn approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wborn wborn merged commit cd0b7cd into openhab:main Dec 30, 2022
@wborn wborn added this to the 4.0 milestone Dec 30, 2022
@cweitkamp cweitkamp deleted the remove-darksky branch December 30, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cweitkamp @wborn