Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added commons-net to openhab-base feature #545

Merged
merged 1 commit into from
Feb 8, 2019
Merged

added commons-net to openhab-base feature #545

merged 1 commit into from
Feb 8, 2019

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer mentioned this pull request Feb 8, 2019
Merged
maggu2810
maggu2810 approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@maggu2810 maggu2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing it in openhab-runtime-base is better then in the core's base.

@maggu2810
Copy link
Contributor

Shouldn't openhab-runtime-base be moved to the distribution?
It's the base feature for the openHAB product and not related to the framework at all.
It does not need to be moved out now, but I assume it should.

@kaikreuzer
Copy link
Member Author

I agree that in some way it is more related to the distribution than to the framework.
But effectively, it defines the API/bundles that openHAB add-ons can expect to be present and to be used. Therefore, this information must be there, when add-ons are built (e.g. in openhab2-addons).
The distro in the end only assembles everything (and thus is built AFTER the core and all add-ons).

@maggu2810 maggu2810 merged commit 208d362 into openhab:master Feb 8, 2019
This was referenced Feb 8, 2019
Closed
Closed
This was referenced Feb 8, 2019
Closed
Closed
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@kaikreuzer @splatch
added commons-net to openhab-base feature (openhab#545)
4bc30a4 
Signed-off-by: Kai Kreuzer <[email protected]>
GitOrigin-RevId: 208d362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggu2810 maggu2810 maggu2810 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@kaikreuzer @maggu2810 @wborn