-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sitemap] Add new element Colortemperaturepicker #4420
Merged
holgerfriedrich
merged 1 commit into
openhab:main
from
lolodomo:color_temperature_picker
Oct 29, 2024
Merged
[sitemap] Add new element Colortemperaturepicker #4420
holgerfriedrich
merged 1 commit into
openhab:main
from
lolodomo:color_temperature_picker
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a594720
to
20a5289
Compare
Related to openhab#3891 Signed-off-by: Laurent Garnier <[email protected]>
20a5289
to
f471a34
Compare
@openhab/core-maintainers : please review & merge this small PR (42 new lines). I would like to give enough time to iOS and Android app to support this new widget before OH 4.3 is released. |
holgerfriedrich
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thank you @holgerfriedrich |
florian-h05
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Nov 30, 2024
Closes #2852. Refs openhab/openhab-core#4420. Related to openhab/openhab-core#3891. This implements configuring a color temperature picker in the sitemap builder UI. It also does some visualisation improvements of names and labels (by defaults shows item label in treeview, analogous to model treeview). --------- Also-by: Florian Hotze <[email protected]> Signed-off-by: Mark Herwege <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3891